[Lldb-commits] [PATCH] D86348: [lldb/DWARF] More DW_AT_const_value fixes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG82982304d709: [lldb/DWARF] More DW_AT_const_value fixes (authored by labath). Changed prior to commit: https://reviews.llvm.org/D86348?vs=287023&i

[Lldb-commits] [PATCH] D86348: [lldb/DWARF] More DW_AT_const_value fixes

aprantl added a comment. Sounds good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86348/new/ https://reviews.llvm.org/D86348 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm

[Lldb-commits] [PATCH] D86348: [lldb/DWARF] More DW_AT_const_value fixes

labath added a comment. In D86348#2231094 , @aprantl wrote: > This looks nice! I'm somewhat suspicious that the new test doesn't > specifically test the union case of the old test, but I'm assuming that would > still work and your simpler tests covers th

[Lldb-commits] [PATCH] D86348: [lldb/DWARF] More DW_AT_const_value fixes

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. LGTM with that caveat Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86348/new/ https://reviews.llvm.org/D86348 __

[Lldb-commits] [PATCH] D86348: [lldb/DWARF] More DW_AT_const_value fixes

aprantl added a comment. This looks nice! I'm somewhat suspicious that the new test doesn't specifically test the union case of the old test, but I'm assuming that would still work and your simpler tests covers the same code? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[Lldb-commits] [PATCH] D86348: [lldb/DWARF] More DW_AT_const_value fixes

shafik added a comment. Thank you finding these additional fixed, it looks good but I don't know some of the details as well as Adrian so I would prefer he gives the LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86348/new/ https://reviews.ll

[Lldb-commits] [PATCH] D86348: [lldb/DWARF] More DW_AT_const_value fixes

labath updated this revision to Diff 287023. labath added a comment. Actually, keep the old const_value test, but give it a bitfield-specific name. Testing bitfields+const_values is still interesting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8

[Lldb-commits] [PATCH] D86348: [lldb/DWARF] More DW_AT_const_value fixes

labath created this revision. labath added reviewers: shafik, aprantl. Herald added a project: LLDB. labath requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: sstefan1, JDevlieghere. This fixes several issues in handling of DW_AT_const_value attributes