[Lldb-commits] [PATCH] D85988: Fix the ability to list iOS simulator processes.

2020-08-19 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. In D85988#2226911 , @JDevlieghere wrote: > In D85988#2226889 , @clayborg wrote: > >> In D85988#2226496 , @aprantl wrote: >> >>> In D85988#616 <

[Lldb-commits] [PATCH] D85988: Fix the ability to list iOS simulator processes.

2020-08-19 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. In D85988#2226889 , @clayborg wrote: > In D85988#2226496 , @aprantl wrote: > >> In D85988#616 , @clayborg wrote: >> >>> Adrian: is there som

[Lldb-commits] [PATCH] D85988: Fix the ability to list iOS simulator processes.

2020-08-19 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. In D85988#2226496 , @aprantl wrote: > In D85988#616 , @clayborg wrote: > >> Adrian: is there something I need to do to enable simulator tests? I added a >> test to TestSimulatorPlatfor

[Lldb-commits] [PATCH] D85988: Fix the ability to list iOS simulator processes.

2020-08-19 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl added a comment. In D85988#616 , @clayborg wrote: > Adrian: is there something I need to do to enable simulator tests? I added a > test to TestSimulatorPlatform.py but if I run: > > $ ../debug/bin/llvm-lit -sv lldb/test/API/macosx/simulator

[Lldb-commits] [PATCH] D85988: Fix the ability to list iOS simulator processes.

2020-08-17 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. Adrian: is there something I need to do to enable simulator tests? I added a test to TestSimulatorPlatform.py but if I run: $ ../debug/bin/llvm-lit -sv lldb/test/API/macosx/simulator llvm-lit: /Users/gclayton/Documents/src/lldb/mono/llvm-project/lldb/test/API/lit.c

[Lldb-commits] [PATCH] D85988: Fix the ability to list iOS simulator processes.

2020-08-17 Thread Greg Clayton via Phabricator via lldb-commits
clayborg updated this revision to Diff 286151. clayborg added a comment. Added a "platform process list" test to each simulator test to test this functionality. The tests all launch processes and the process should be stopped at a breakpoint, so listing the processes for "ios-simulator" is a gr

[Lldb-commits] [PATCH] D85988: Fix the ability to list iOS simulator processes.

2020-08-14 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. We should have a few tests that launch a simulator. @aprantl revived them recently: - TestAppleSimulatorOSType.py - TestSimulatorPlatform.py - TestIOSSimulator.py Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85988/ne

[Lldb-commits] [PATCH] D85988: Fix the ability to list iOS simulator processes.

2020-08-14 Thread Greg Clayton via Phabricator via lldb-commits
clayborg created this revision. clayborg added reviewers: labath, aprantl, JDevlieghere, jingham, jasonmolenda. Herald added a project: LLDB. clayborg requested review of this revision. This can be done by doing: (lldb) platform select ios-simulator (lldb) platform process list There was code tha