[Lldb-commits] [PATCH] D84126: Enable -Wsuggest-override in the LLVM build

logan-5 added a comment. In D84126#2171469 , @labath wrote: > Instead of adding -Wno-suggest-override to every user it might be cleaner to > add the flag to the INTERFACE_COMPILE_OPTIONS property of the relevant > targets (gtest, gmock, and gbenchmark ?)

[Lldb-commits] [PATCH] D84126: Enable -Wsuggest-override in the LLVM build

labath added a comment. Instead of adding -Wno-suggest-override to every user it might be cleaner to add the flag to the INTERFACE_COMPILE_OPTIONS property of the relevant targets (gtest, gmock, and gbenchmark ?). That way, anything which links against these will inherit it automatically. Rep

[Lldb-commits] [PATCH] D84126: Enable -Wsuggest-override in the LLVM build

nemanjai added a comment. Herald added a subscriber: wuzish. There is a lot of instances where this warning fires in the unit tests since gtest does not appear to use the `override` keyword. This in turn causes failures on bootstrap builds that use `-Werror`. An example: http://lab.llvm.org:801

[Lldb-commits] [PATCH] D84126: Enable -Wsuggest-override in the LLVM build

logan-5 added a comment. In D84126#2165585 , @nemanjai wrote: > There is a lot of instances where this warning fires in the unit tests since > gtest does not appear to use the `override` keyword. This in turn causes > failures on bootstrap builds that us

[Lldb-commits] [PATCH] D84126: Enable -Wsuggest-override in the LLVM build

logan-5 added a comment. In D84126#2166952 , @erichkeane wrote: > I'd suggest disabling this unless the GCC version is >9.1. I've got a patch addressing exactly this issue here, hoping to get it landed soon: https://reviews.llvm.org/D84292 Thanks again

[Lldb-commits] [PATCH] D84126: Enable -Wsuggest-override in the LLVM build

erichkeane added a comment. Ive got a bit a of a problem here: This flag (suggest-override) on GCC 8.3 (and others) warns on missing-override EVEN WHEN the function is marked 'final'. This was not fixed until GCC 9.2: https://godbolt.org/z/55KeM3 The result is my build gave a few thousand diag

[Lldb-commits] [PATCH] D84126: Enable -Wsuggest-override in the LLVM build

logan-5 created this revision. logan-5 added reviewers: dblaikie, rnk, aaron.ballman, ldionne. Herald added subscribers: llvm-commits, libcxx-commits, lldb-commits, lebedev.ri, dexonsmith, mgorny. Herald added a reviewer: lebedev.ri. Herald added projects: LLDB, libc++, libc++abi, LLVM. Herald add

[Lldb-commits] [PATCH] D84126: Enable -Wsuggest-override in the LLVM build

logan-5 added a comment. All the failures related to this patch are now resolved as far as I can tell. I'm very sorry for the trouble. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84126/new/ https://reviews.llvm.org/D84126

[Lldb-commits] [PATCH] D84126: Enable -Wsuggest-override in the LLVM build

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b16e45f66e2: Enable -Wsuggest-override in the LLVM build (authored by logan-5). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84126/new/ https://reviews.ll

[Lldb-commits] [PATCH] D84126: Enable -Wsuggest-override in the LLVM build

xbolva00 added a comment. +1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84126/new/ https://reviews.llvm.org/D84126 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cg