JDevlieghere added a comment.
This broke the Windows build:
http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/17701
Can you take a look?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83541/new/
https://reviews.llvm.org/D83541
___
This revision was automatically updated to reflect the committed changes.
Closed by commit rG7ca9b589c453: Remove Linux sysroot dependencies of SVE PT
macros (authored by omjavaid).
Herald added a project: LLDB.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.ll
omjavaid updated this revision to Diff 279152.
omjavaid added a comment.
One minor last minute change.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83541/new/
https://reviews.llvm.org/D83541
Files:
lldb/source/Plugins/Process/Linux/LinuxPTraceDefines_arm64sve.h
lldb/source/Plugins
omjavaid updated this revision to Diff 277702.
omjavaid added a comment.
This update addresses concerns raised in last iteration.
LGTM?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83541/new/
https://reviews.llvm.org/D83541
Files:
lldb/source/Plugins/Process/Linux/LinuxPTraceDefine
labath added a comment.
To use this code from Process/elf-core, we also need to move this file.
`source/Plugins/Process/Utility` is the best place we got for this right now.
Comment at: lldb/source/Plugins/Process/Linux/LinuxPTraceDefines_arm64sve.h:9-10
#ifndef lldb_LinuxP
omjavaid created this revision.
omjavaid added a reviewer: labath.
Herald added subscribers: kristof.beyls, tschuett.
Herald added a reviewer: rengolin.
SVE elf note data requires SVE PT macros for reading writing data. Same macros
are used by Linux ptrace SVE register access.
This patch makes n
