[Lldb-commits] [PATCH] D83180: Set generic error in SBError SetErrorToGenericError

2020-10-29 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor resigned from this revision. teemperor added a comment. Herald added a reviewer: JDevlieghere. D90151 landed and addressed/tested this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83180/new/ https://rev

[Lldb-commits] [PATCH] D83180: Set generic error in SBError SetErrorToGenericError

2020-07-15 Thread Konrad Wilhelm Kleine via Phabricator via lldb-commits
kwk added a comment. LGTM but a test would indeed be nice. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83180/new/ https://reviews.llvm.org/D83180 ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [PATCH] D83180: Set generic error in SBError SetErrorToGenericError

2020-07-06 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. I suspect this was a copy/paste mistake. Could you add a small test for this? Other than that this LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83180/new/ https://reviews.llvm.org/D83180 _

[Lldb-commits] [PATCH] D83180: Set generic error in SBError SetErrorToGenericError

2020-07-05 Thread Shivam Mittal via Phabricator via lldb-commits
shivammittal99 created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Signed-off-by: Shivam Mittal Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83180 Files: lldb/source/API/SBError.cpp Index: lldb/source/API/SBError.cpp ===