This revision was automatically updated to reflect the committed changes.
labath marked an inline comment as done.
Closed by commit rG35674976f09e: [lldb/Test] Introduce
"assertSuccess" (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D82759?vs=274070&id=274459#toc
Repos
labath marked 3 inline comments as done.
labath added inline comments.
Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:2537
+def assertSuccess(self, obj, msg=None):
+if not obj.Success():
+error = obj.GetCString()
teemperor wro
teemperor accepted this revision.
teemperor added a comment.
LGTM, thanks!
Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:2537
+def assertSuccess(self, obj, msg=None):
+if not obj.Success():
+error = obj.GetCString()
JDevlie
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
Looks like a great improvement!
At some point we should document our custom methods in
https://lldb.llvm.org/resources/test.html to make them more discoverable, but
that's orthogo
labath created this revision.
labath added reviewers: teemperor, JDevlieghere.
Herald added a subscriber: arphaman.
Herald added a project: LLDB.
A lot of our tests do 'self.assertTrue(error.Success()'. The problem
with that is that when this fails, it produces a completely useless
error message (
