[Lldb-commits] [PATCH] D79654: [lldb/Driver] Support terminal resizing

This revision was automatically updated to reflect the committed changes. Closed by commit rGd9166ad27284: [lldb/Driver] Support terminal resizing (authored by friss). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79654/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D79654: [lldb/Driver] Support terminal resizing

labath added a comment. Yes, you're right that the current implementation of Editline::Interrupt is not correct. It's kind of my fault since I added that locking code (in my defense, the code was pretty messy to begin with). The implementation could indeed deadlock if the signal is delivered on

[Lldb-commits] [PATCH] D79654: [lldb/Driver] Support terminal resizing

friss added a comment. In D79654#2030635 , @friss wrote: > > If we wanted to avoid delaying the change to the next keystroke, we could > > reuse the same mechanism that ^C/SIGINT uses > > (`m_input_connection.InterruptRead()`). That would probably requir

[Lldb-commits] [PATCH] D79654: [lldb/Driver] Support terminal resizing

friss added a comment. In D79654#2029131 , @labath wrote: > Yes, resizing the window (or doing any other nontrivial task) from within a > signal handler is a bad idea. Making a note of the signal and then bailing > out is the right approach. Though, to b

[Lldb-commits] [PATCH] D79654: [lldb/Driver] Support terminal resizing

friss updated this revision to Diff 263331. friss added a comment. Herald added a subscriber: jfb. Use sig_atomic_t as Pavel suggested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79654/new/ https://reviews.llvm.org/D79654 Files: lldb/include/l

[Lldb-commits] [PATCH] D79654: [lldb/Driver] Support terminal resizing

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Yes, resizing the window (or doing any other nontrivial task) from within a signal handler is a bad idea. Making a note of the signal and then bailing out is the right approach. Though, to be

[Lldb-commits] [PATCH] D79654: [lldb/Driver] Support terminal resizing

friss created this revision. friss added reviewers: labath, teemperor. Herald added a project: LLDB. The comment in the Editine.h header made it sound like editline was just unable to handle terminal resizing. We were not ever telling editline that the terminal had changed size, which might explai