[Lldb-commits] [PATCH] D77602: [lldb/Reproducers] Support inline replay

2020-04-13 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere updated this revision to Diff 257057. JDevlieghere added a comment. Add unit tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77602/new/ https://reviews.llvm.org/D77602 Files: lldb/include/lldb/Utility/Reproducer.h lldb/include/lldb/Utility/ReproducerInstrumentation

[Lldb-commits] [PATCH] D77602: [lldb/Reproducers] Support inline replay

2020-04-09 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere updated this revision to Diff 256505. JDevlieghere added a comment. - Simplify `LLDB_RECORD_CONSTRUCTOR` macro. The other macros have `return` statements that need to be inlined in the caller for replay, and the boundary tracking needs to be updated right, so I'm not convinced the e

[Lldb-commits] [PATCH] D77602: [lldb/Reproducers] Support inline replay

2020-04-09 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. I haven't looked at the code in details, but some of my high-level concerns are: - the `LLDB_RECORD_***` macros are getting rather long and repetitive. We should try to find a way to move some of that stuff into a regular function and keep the macros for the stuff that c

[Lldb-commits] [PATCH] D77602: [lldb/Reproducers] Support inline replay

2020-04-06 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere created this revision. JDevlieghere added a reviewer: labath. Herald added a subscriber: abidh. JDevlieghere added a parent revision: D77588: [lldb/Reproducers] Make it possible to capture reproducers for the Python test suite.. Support inline replay as described in the RFC [1] on ll