[Lldb-commits] [PATCH] D75848: [lldb] Make UnwindLLDB a non-plugin

2020-03-10 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd00dff88b402: [lldb] Make UnwindLLDB a non-plugin (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75848/new/ https://reviews.llvm.org/D7

[Lldb-commits] [PATCH] D75848: [lldb] Make UnwindLLDB a non-plugin

2020-03-09 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda accepted this revision. jasonmolenda added a comment. Thanks for doing this, lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75848/new/ https://reviews.llvm.org/D75848 ___ lldb-commits

[Lldb-commits] [PATCH] D75848: [lldb] Make UnwindLLDB a non-plugin

2020-03-09 Thread Alex Langford via Phabricator via lldb-commits
xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. Thanks for doing this. LGTM, might want to wait for Jason's approval like Jonas said though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D758

[Lldb-commits] [PATCH] D75848: [lldb] Make UnwindLLDB a non-plugin

2020-03-09 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. Jason should make the call but looks good to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75848/new/ https://reviews.llvm.org/D75848 ___ lldb-commits mailing list lldb

[Lldb-commits] [PATCH] D75848: [lldb] Make UnwindLLDB a non-plugin

2020-03-09 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. labath added reviewers: jasonmolenda, JDevlieghere, xiaobai. Herald added a subscriber: mgorny. Herald added a project: LLDB. This is the only real unwinder, and things have been this way for quite a long time. At this point, the class has accumulated so many features