[Lldb-commits] [PATCH] D74727: Allow customized relative PYTHONHOME

hans added a comment. Herald added a project: All. In D74727#1887325 , @stella.stamenova wrote: > It looks like this broke the Windows LLDB Buildbot: > > http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/14048/steps/build/logs/stdio Seems i

[Lldb-commits] [PATCH] D74727: Allow customized relative PYTHONHOME

stella.stamenova added a comment. It looks like this broke the Windows LLDB Buildbot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/14048/steps/build/logs/stdio Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74727/new/ https://rev

[Lldb-commits] [PATCH] D74727: Allow customized relative PYTHONHOME

This revision was automatically updated to reflect the committed changes. Closed by commit rG0bb90628b5f7: Allow customized relative PYTHONHOME (authored by hhb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74727/new/ https://reviews.llvm.org/D747

[Lldb-commits] [PATCH] D74727: Allow customized relative PYTHONHOME

hhb updated this revision to Diff 245770. hhb added a comment. The code should check on LLDB_EMBED_PYTHON_HOME Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74727/new/ https://reviews.llvm.org/D74727 Files: lldb/cmake/modules/LLDBConfig.cmake

[Lldb-commits] [PATCH] D74727: Allow customized relative PYTHONHOME

hhb updated this revision to Diff 245750. hhb added a comment. Move option() into if Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74727/new/ https://reviews.llvm.org/D74727 Files: lldb/cmake/modules/LLDBConfig.cmake lldb/source/Plugins/Script

[Lldb-commits] [PATCH] D74727: Allow customized relative PYTHONHOME

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This looks good to me. Comment at: lldb/cmake/modules/LLDBConfig.cmake:68-70 +option(LLDB_EMBED_PYTHON_HOME + "Embed PYTHONHOME in the binary. If set to OFF, PYTHONHOME

[Lldb-commits] [PATCH] D74727: Allow customized relative PYTHONHOME

hhb updated this revision to Diff 245499. hhb added a comment. Rename LLDB_RELOCATABLE_PYTHON to LLDB_EMBED_PYTHON_HOME. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74727/new/ https://reviews.llvm.org/D74727 Files: lldb/cmake/modules/LLDBConfi

[Lldb-commits] [PATCH] D74727: Allow customized relative PYTHONHOME

labath added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:298 +llvm::sys::path::append(path, lldb_python_home); +llvm::sys::path::remove_dots(path, /* remove_dot_dots = */ true); +absolute_python_ho

[Lldb-commits] [PATCH] D74727: Allow customized relative PYTHONHOME

labath added a comment. In D74727#1881962 , @JDevlieghere wrote: > In D74727#1881055 , @hhb wrote: > > > > Can we maybe rename it to something like that? > > > > LLDB_RELOCATABLE_PYTHON is misleading. I'd be happy

[Lldb-commits] [PATCH] D74727: Allow customized relative PYTHONHOME

JDevlieghere added a comment. In D74727#1881055 , @hhb wrote: > > Can we maybe rename it to something like that? > > LLDB_RELOCATABLE_PYTHON is misleading. I'd be happy to rename it. But that > may break people who already set this flag. > > Is there a st

[Lldb-commits] [PATCH] D74727: Allow customized relative PYTHONHOME

hhb marked an inline comment as done. hhb added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:298 +llvm::sys::path::append(path, lldb_python_home); +llvm::sys::path::remove_dots(path, /* remove_dot_dots = */

[Lldb-commits] [PATCH] D74727: Allow customized relative PYTHONHOME

hhb added a comment. > Can we maybe rename it to something like that? LLDB_RELOCATABLE_PYTHON is misleading. I'd be happy to rename it. But that may break people who already set this flag. Is there a standard procedure to do this? Maybe add the new one and remove the old one a year later? Or m

[Lldb-commits] [PATCH] D74727: Allow customized relative PYTHONHOME

hhb updated this revision to Diff 245211. hhb added a comment. Fix comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74727/new/ https://reviews.llvm.org/D74727 Files: lldb/cmake/modules/LLDBConfig.cmake lldb/source/Plugins/ScriptInterpre

[Lldb-commits] [PATCH] D74727: Allow customized relative PYTHONHOME

hhb updated this revision to Diff 245206. hhb marked 5 inline comments as done. hhb added a comment. Fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74727/new/ https://reviews.llvm.org/D74727 Files: lldb/cmake/modules/LLDBConfig.cmake

[Lldb-commits] [PATCH] D74727: Allow customized relative PYTHONHOME

labath added a reviewer: ted. labath added a comment. + ted, who I believe has a stake in the relocatable python game Your use case seems reasonable, but I find it hard to understand the meanings of the options in this patch. IIUC, there are now two ways to create an lldb with a "relocatable" p

[Lldb-commits] [PATCH] D74727: Allow customized relative PYTHONHOME

hhb created this revision. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. hhb edited the summary of this revision. hhb added a reviewer: labath. This change allows a hard coded relative PYTHONHOME setting. So that python can easily be packaged together with lldb. T