JDevlieghere added a comment.
Awesome, thank you! This has been on my todo-list for awhile :-)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70827/new/
https://reviews.llvm.org/D70827
___
lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rG38870af85947: [lldb] Remove FileSpec->CompileUnit
inheritance (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D70827?vs=231438&id=231509#toc
Repository:
rG LLVM Github Monorep
labath updated this revision to Diff 231438.
labath added a comment.
- add doxygen for the new member
- avoid using the magic pointer constructor in SearchFilter.cpp
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70827/new/
https://reviews.llvm.org/
labath marked 2 inline comments as done.
labath added inline comments.
Comment at: lldb/source/Commands/CommandObjectThread.cpp:1196
start_idx_ptr = sc.comp_unit->FindLineEntry(
-start_idx_ptr, line_number, sc.comp_unit, exact, &line_entry);
+
labath created this revision.
labath added reviewers: teemperor, JDevlieghere.
Herald added a reviewer: jdoerfert.
Herald added a project: LLDB.
labath marked 2 inline comments as done.
labath added inline comments.
Comment at: lldb/source/Commands/CommandObjectThread.cpp:1196
