This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rG9b958356983a: [LLDB] Add core definition for armv8l and
armv7l (authored by omjavaid).
Herald added a project: LLDB.
Chan
omjavaid marked an inline comment as done.
omjavaid added a comment.
I have updated the patch as suggested and will move out the triple fix and
whitespace issue in separate patches. Committing remaining changes shortly.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69904/new/
https://r
labath added a comment.
Everything except the `CoreUpdated` part LGTM. The CoreUpdated part could use
another look from someone more familiar with what exactly that code was trying
to achieve. And a test... I'd consider breaking that off into a separate patch.
Comment at: lld
omjavaid created this revision.
omjavaid added reviewers: jasonmolenda, labath, clayborg.
Herald added a subscriber: kristof.beyls.
This patch adds core definitions in lldb ArchSpecs for armv8l and armv7l cores.
There is also fix where while merging target and paltform triple we were
updating co
