[Lldb-commits] [PATCH] D69612: [lldb-vscod] fix build with NDEBUG on windows

labath added a comment. In D69612#1726968 , @labath wrote: > Yes, I used "arc patch". I did check that it preserved the authorship > information, but I did not go into the details of what's in the author field > TBH. I agree it would be better to have th

[Lldb-commits] [PATCH] D69612: [lldb-vscod] fix build with NDEBUG on windows

labath added a comment. It ended up being a separate commit (2d1a0dfe ) because I don't know how to use git. :P As far as change attribution is concerned, that may be even for the better. :) Repository: rG LLVM Github Mono

[Lldb-commits] [PATCH] D69612: [lldb-vscod] fix build with NDEBUG on windows

amccarth added a comment. In D69612#1726849 , @SquallATF wrote: > In D69612#1726829 , @labath wrote: > > > LGTM, modulo the `(void) result` stuff. Do you need someone to commit this > > for you? > > > Yes I need.

[Lldb-commits] [PATCH] D69612: [lldb-vscod] fix build with NDEBUG on windows

labath added a comment. Yes, I used "arc patch". I did check that it preserved the authorship information, but I did not go into the details of what's in the author field TBH. I agree it would be better to have the full name there, but I don't know if there's a way to change that (short of peop

[Lldb-commits] [PATCH] D69612: [lldb-vscod] fix build with NDEBUG on windows

mstorsjo added a comment. I presume you applied the patch with `arc patch`? It seems to apply the Phabricator username as git user, which is a bit odd, as it is customary to use realnames in the git author field. Earlier, when everything ended up mangled by svn, everything ended up normalized t

[Lldb-commits] [PATCH] D69612: [lldb-vscod] fix build with NDEBUG on windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG2dbcfad35de6: [lldb-vscod] fix build with NDEBUG on windows (authored by SquallATF, committed by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69612

[Lldb-commits] [PATCH] D69612: [lldb-vscod] fix build with NDEBUG on windows

SquallATF added a comment. In D69612#1726829 , @labath wrote: > LGTM, modulo the `(void) result` stuff. Do you need someone to commit this > for you? Yes I need. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D69612: [lldb-vscod] fix build with NDEBUG on windows

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. LGTM, modulo the `(void) result` stuff. Do you need someone to commit this for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69612/new/ ht

[Lldb-commits] [PATCH] D69612: [lldb-vscod] fix build with NDEBUG on windows

mstorsjo added reviewers: labath, amccarth. mstorsjo added a comment. Good catch, thanks! But would we need to add something like `(void)result;` to silence potential compiler warnings about an unused (or set but not read) variable? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[Lldb-commits] [PATCH] D69612: [lldb-vscod] fix build with NDEBUG on windows

SquallATF created this revision. SquallATF added a reviewer: mstorsjo. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. _setmode in assert will not run when build with NDEBUG Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69612 Files: lldb/tools/lldb-vs