[Lldb-commits] [PATCH] D69119: Modernize the rest of the Find.* API (NFC)

ted added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69119/new/ https://reviews.llvm.org/D69119 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[Lldb-commits] [PATCH] D69119: Modernize the rest of the Find.* API (NFC)

saugustine added a comment. This breaks the build due to lldb/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:1355:8: error: unused variable 'old_size' [-Werror,-Wunused-variable] I will check in a fix shortly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[Lldb-commits] [PATCH] D69119: Modernize the rest of the Find.* API (NFC)

labath accepted this revision. labath added a comment. yay Comment at: lldb/tools/lldb-test/lldb-test.cpp:439-448 +List.Clear(); +Symfile.FindFunctions(RE, true, List); } else { Expected ContextOr = getDeclContext(Symfile); if (!ContextOr) return Con

[Lldb-commits] [PATCH] D69119: Modernize the rest of the Find.* API (NFC)

teemperor added a comment. +1 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69119/new/ https://reviews.llvm.org/D69119 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits