This revision was automatically updated to reflect the committed changes.
Closed by commit rG62c9fe4273e8: uint32_t options -> File::OpenOptions
options (authored by lawrence_danna).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68853/new/
https://r
labath accepted this revision.
labath added inline comments.
This revision is now accepted and ready to land.
Comment at: lldb/source/Host/common/File.cpp:42
-static const char *GetStreamOpenModeFromOptions(uint32_t options) {
+static Expected GetStreamOpenModeFromOptions(uint3
lawrence_danna updated this revision to Diff 224658.
lawrence_danna added a comment.
fix
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68853/new/
https://reviews.llvm.org/D68853
Files:
lldb/include/lldb/Core/StreamFile.h
lldb/include/lldb/Host
lawrence_danna added inline comments.
Comment at: lldb/source/Host/common/File.cpp:42
-static const char *GetStreamOpenModeFromOptions(uint32_t options) {
+static Expected GetStreamOpenModeFromOptions(uint32_t options) {
if (options & File::eOpenOptionAppend) {
-
lawrence_danna updated this revision to Diff 224631.
lawrence_danna marked 5 inline comments as done.
lawrence_danna added a comment.
review fixes
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68853/new/
https://reviews.llvm.org/D68853
Files:
ll
labath added a comment.
I originally thought you would do something local, but changing this across the
board is definitely better, and it doesn't seem the patch is that big. LLVM
already has a utility to work out the kinks in the bitmask enum use case.
Please take a look at `llvm/ADT/BitmaskEn
lawrence_danna created this revision.
lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath.
Herald added a project: LLDB.
This patch re-types everywhere that passes a File::OpenOptions
as a uint32_t so it actually uses File::OpenOptions.
It also converts some OpenOptions related fun
