This revision was automatically updated to reflect the committed changes.
Closed by commit rG939411c1aaa8: Remove the is_mangled flag from Mangled and
Symbol (authored by aprantl).
Herald added a project: LLDB.
Changed prior to commit:
https://reviews.llvm.org/D68674?vs=223965&id=224079#toc
Re
labath accepted this revision.
labath added a comment.
Looks like a nice cleanup, if we can get away with that. I tried to come up
with a situation where we would have a more authoritative source on whether
something is mangled or not than just looking at the string, but I haven't come
up with
JDevlieghere accepted this revision.
JDevlieghere added a comment.
Neat!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68674/new/
https://reviews.llvm.org/D68674
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.o
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68674/new/
https://reviews.llvm.org/D68674
___
lldb-commits mailing list
lldb-commits
aprantl updated this revision to Diff 223965.
aprantl added a comment.
Updated unit test.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68674/new/
https://reviews.llvm.org/D68674
Files:
lldb/include/lldb/Core/Mangled.h
lldb/include/lldb/Symbol/Function.h
lldb/include/lldb/Symbol/
aprantl created this revision.
aprantl added reviewers: JDevlieghere, jasonmolenda, labath.
Herald added subscribers: MaskRay, arichardson, emaste.
Herald added a reviewer: espindola.
Testing whether a name is mangled or not is extremely cheap and can be done by
looking at the first two character