Re: [Lldb-commits] [PATCH] D68641: [LLDB] Fix for synthetic children memory leak

I'll have a look, sorry about that. On Wed, Oct 9, 2019 at 4:37 PM Shafik Yaghmour via Phabricator < revi...@reviews.llvm.org> wrote: > shafik added a comment. > > This change broek the`TestDataFormatterInvalidStdUniquePtr.py` test, see: > http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/2

[Lldb-commits] [PATCH] D68641: [LLDB] Fix for synthetic children memory leak

cameron314 added a comment. I've committed a fix in rG745e57c5939e . Sorry about that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68641/new/ https://reviews.llvm.org/D68641

[Lldb-commits] [PATCH] D68641: [LLDB] Fix for synthetic children memory leak

shafik added a comment. This change broek the`TestDataFormatterInvalidStdUniquePtr.py` test, see: http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/2411/testReport/ I verified that reverting this commit fixes the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[Lldb-commits] [PATCH] D68641: [LLDB] Fix for synthetic children memory leak

This revision was automatically updated to reflect the committed changes. Closed by commit rG89386daa9571: [LLDB] Fix for synthetic children memory leak (authored by cameron314). Changed prior to commit: https://reviews.llvm.org/D68641?vs=223919&id=224112#toc Repository: rG LLVM Github Monor

[Lldb-commits] [PATCH] D68641: [LLDB] Fix for synthetic children memory leak

aprantl added a comment. Please go ahead! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68641/new/ https://reviews.llvm.org/D68641 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lld

[Lldb-commits] [PATCH] D68641: [LLDB] Fix for synthetic children memory leak

cameron314 added a comment. Any objections before I commit? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68641/new/ https://reviews.llvm.org/D68641 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[Lldb-commits] [PATCH] D68641: [LLDB] Fix for synthetic children memory leak

cameron314 updated this revision to Diff 223919. cameron314 added a comment. Added comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68641/new/ https://reviews.llvm.org/D68641 Files: source/Plugins/Language/CPlusPlus/LibCxxBitset.cpp source/Plugins/Language/CPlusPlus/LibCxxOp

[Lldb-commits] [PATCH] D68641: [LLDB] Fix for synthetic children memory leak

cameron314 added a comment. Right, I'll add comments on the pointer declarations. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68641/new/ https://reviews.llvm.org/D68641 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [PATCH] D68641: [LLDB] Fix for synthetic children memory leak

shafik accepted this revision. shafik added a comment. LGTM Comment at: source/Plugins/Language/CPlusPlus/LibCxxBitset.cpp:34 std::vector m_elements; - ValueObjectSP m_first; + ValueObject* m_first = nullptr; CompilerType m_bool_type; I feel like each o

[Lldb-commits] [PATCH] D68641: [LLDB] Fix for synthetic children memory leak

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Cool. May be nice to put a comment on the pointer why this is safe. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68641/new/ https://reviews.llvm.org/D6864

[Lldb-commits] [PATCH] D68641: [LLDB] Fix for synthetic children memory leak

cameron314 added a comment. @aprantl No. A weak pointer would still fix the memory leak, but it's safe to use a raw pointer because we only reference objects which are in the same cluster as the synthetic children front-end itself. The other (leak-free) synthetic front-ends do this as well. We

[Lldb-commits] [PATCH] D68641: [LLDB] Fix for synthetic children memory leak

aprantl added a comment. Disclaimer: I'm not familiar with this code. Would it be safe/better to store a weak pointer instead of a raw pointer? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68641/new/ https://reviews.llvm.org/D68641

[Lldb-commits] [PATCH] D68641: [LLDB] Fix for synthetic children memory leak

cameron314 created this revision. cameron314 added reviewers: labath, jingham. cameron314 added a project: LLDB. Herald added subscribers: lldb-commits, JDevlieghere, aprantl. This fixes a memory leak with several synthetic children front-ends. The lifetime of a ValueObject and all its derivative