[Lldb-commits] [PATCH] D68442: [lldb] Unifying lldb python path

hhb closed this revision. hhb added a comment. This is merged as 61f471a and 0016b45 . Closing... Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[Lldb-commits] [PATCH] D68442: [lldb] Unifying lldb python path

hhb updated this revision to Diff 223701. hhb added a comment. Reverts the change related to python dir for windows. FileSpec should always contain normalized path. I.e. using '/' even in windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68442

[Lldb-commits] [PATCH] D68442: [lldb] Unifying lldb python path

hhb updated this revision to Diff 223689. hhb added a comment. Converts python output path to cmake format. This looks like a bug on windows exists before this change... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68442/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D68442: [lldb] Unifying lldb python path

hhb added a comment. In D68442#1698053 , @mgorny wrote: > Cool work. I presume you've tested it. I can test it tomorrow if you need me > to. However, I can do that after the commit. I'm doing a final round of testing on linux/darwin/windows(mingw). I'll

[Lldb-commits] [PATCH] D68442: [lldb] Unifying lldb python path

mgorny accepted this revision. mgorny added a comment. Cool work. I presume you've tested it. I can test it tomorrow if you need me to. However, I can do that after the commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68442/new/ https://revie

[Lldb-commits] [PATCH] D68442: [lldb] Unifying lldb python path

hhb updated this revision to Diff 223638. hhb marked an inline comment as done. hhb added a comment. Fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68442/new/ https://reviews.llvm.org/D68442 Files: lldb/CMakeLists.txt lldb/scripts/

[Lldb-commits] [PATCH] D68442: [lldb] Unifying lldb python path

hhb marked 3 inline comments as done and an inline comment as not done. hhb added inline comments. Comment at: lldb/CMakeLists.txt:42 +COMMAND ${PYTHON_EXECUTABLE} +-c "import distutils.sysconfig, sys; print(distutils.sysconfig.get_python_lib(True, False, sys.argv[1]

[Lldb-commits] [PATCH] D68442: [lldb] Unifying lldb python path

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Thanks for the cleanup. This looks fine to me. I'll leave it up to you to figure out the best way to compute the relative python path... Comment at: lldb/CMakeLists.txt:42 +

[Lldb-commits] [PATCH] D68442: [lldb] Unifying lldb python path

mgorny added inline comments. Comment at: lldb/CMakeLists.txt:42 +COMMAND ${PYTHON_EXECUTABLE} +-c "import distutils.sysconfig, sys; print(distutils.sysconfig.get_python_lib(True, False, sys.argv[1]))" +${CMAKE_INSTALL_PREFIX} hhb wrote: > hh

[Lldb-commits] [PATCH] D68442: [lldb] Unifying lldb python path

hhb marked an inline comment as not done. hhb added inline comments. Comment at: lldb/CMakeLists.txt:42 +COMMAND ${PYTHON_EXECUTABLE} +-c "import distutils.sysconfig, sys; print(distutils.sysconfig.get_python_lib(True, False, sys.argv[1]))" +${CMAKE_INSTALL_P

[Lldb-commits] [PATCH] D68442: [lldb] Unifying lldb python path

hhb marked an inline comment as done. hhb added inline comments. Comment at: lldb/CMakeLists.txt:42 +COMMAND ${PYTHON_EXECUTABLE} +-c "import distutils.sysconfig, sys; print(distutils.sysconfig.get_python_lib(True, False, sys.argv[1]))" +${CMAKE_INSTALL_PREFI

[Lldb-commits] [PATCH] D68442: [lldb] Unifying lldb python path

mgorny added inline comments. Comment at: lldb/CMakeLists.txt:42 +COMMAND ${PYTHON_EXECUTABLE} +-c "import distutils.sysconfig, sys; print(distutils.sysconfig.get_python_lib(True, False, sys.argv[1]))" +${CMAKE_INSTALL_PREFIX} I still like my

[Lldb-commits] [PATCH] D68442: [lldb] Unifying lldb python path

hhb updated this revision to Diff 223346. hhb added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68442/new/ https://reviews.llvm.org/D68442 Files: lldb/CMakeLists.txt lldb/scripts/CMakeLists.txt lldb/scripts/Python/finishS

[Lldb-commits] [PATCH] D68442: [lldb] Unifying lldb python path

hhb updated this revision to Diff 223135. hhb added a comment. Fix description.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68442/new/ https://reviews.llvm.org/D68442 Files: lldb/CMakeLists.txt lldb/scripts/CMakeLists.txt lldb/scripts/Pyt