[Lldb-commits] [PATCH] D68312: [gdb-remote] process properly effective uid

2019-10-08 Thread walter erquinigo via Phabricator via lldb-commits
wallace closed this revision. wallace added a comment. already committed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68312/new/ https://reviews.llvm.org/D68312 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D68312: [gdb-remote] process properly effective uid

2019-10-04 Thread walter erquinigo via Phabricator via lldb-commits
wallace updated this revision to Diff 223359. wallace added a comment. added a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68312/new/ https://reviews.llvm.org/D68312 Files: lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_c

[Lldb-commits] [PATCH] D68312: [gdb-remote] process properly effective uid

2019-10-02 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Someone also didn't write a test for that. :) Let's not make the same mistake. The same two options I mentioned in D68293 should apply here too, though for this case, I would slightly prefer the c++ unit test route, as it will isolate yo

[Lldb-commits] [PATCH] D68312: [gdb-remote] process properly effective uid

2019-10-01 Thread walter erquinigo via Phabricator via lldb-commits
wallace created this revision. wallace added reviewers: labath, clayborg, aadsm, xiaobai. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Someone wrote SetEffectiveSetEffectiveGroupID instead of SetEffectiveUserID. After this fix, the android process list can show user name