[Lldb-commits] [PATCH] D68007: [lldb] Move swig call from python code to cmake

JDevlieghere added inline comments. Comment at: lldb/trunk/scripts/CMakeLists.txt:5 + ${LLDB_SOURCE_DIR}/include/lldb/API/*.h + ${LLDB_SOURCE_DIR}/include/lldb/*.h ) xiaobai wrote: > hhb wrote: > > xiaobai wrote: > > > Doesn't this now include the `lldb-privat

[Lldb-commits] [PATCH] D68007: [lldb] Move swig call from python code to cmake

xiaobai added inline comments. Comment at: lldb/trunk/scripts/CMakeLists.txt:5 + ${LLDB_SOURCE_DIR}/include/lldb/API/*.h + ${LLDB_SOURCE_DIR}/include/lldb/*.h ) hhb wrote: > xiaobai wrote: > > Doesn't this now include the `lldb-private` headers now? Is that in

[Lldb-commits] [PATCH] D68007: [lldb] Move swig call from python code to cmake

hhb marked an inline comment as done. hhb added inline comments. Comment at: lldb/trunk/scripts/CMakeLists.txt:5 + ${LLDB_SOURCE_DIR}/include/lldb/API/*.h + ${LLDB_SOURCE_DIR}/include/lldb/*.h ) xiaobai wrote: > Doesn't this now include the `lldb-private` head

[Lldb-commits] [PATCH] D68007: [lldb] Move swig call from python code to cmake

xiaobai added inline comments. Comment at: lldb/trunk/scripts/CMakeLists.txt:5 + ${LLDB_SOURCE_DIR}/include/lldb/API/*.h + ${LLDB_SOURCE_DIR}/include/lldb/*.h ) Doesn't this now include the `lldb-private` headers now? Is that intended? Repository: rL LLVM

[Lldb-commits] [PATCH] D68007: [lldb] Move swig call from python code to cmake

This revision was automatically updated to reflect the committed changes. Closed by commit rL372895: [lldb] Move swig call from python code to cmake (authored by hhb, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.

[Lldb-commits] [PATCH] D68007: [lldb] Move swig call from python code to cmake

labath accepted this revision. labath added a comment. Yay, tons of nasty python code going down the drain. This looks fine, but please take it slowly when landing these patches. Waiting a day or two before proceeding with the next patch will make it easier to fix things up if any of them cause

[Lldb-commits] [PATCH] D68007: [lldb] Move swig call from python code to cmake

hhb added a comment. In D68007#1681908 , @mgorny wrote: > I'm kinda surprised we don't need site-packages path there after all. Yes that's surprising. Seems like it is better to move the install() call in your change to lldb/CMakeLists.txt. To be togeth

[Lldb-commits] [PATCH] D68007: [lldb] Move swig call from python code to cmake

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Thanks! That's a great job, and certainly saves me some trouble in pushing my patch forward, though I'm kinda surprised we don't need site-packages path there after all. Please wait for other

[Lldb-commits] [PATCH] D68007: [lldb] Move swig call from python code to cmake

hhb updated this revision to Diff 221667. hhb added a comment. Format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68007/new/ https://reviews.llvm.org/D68007 Files: lldb/scripts/CMakeLists.txt lldb/scripts/Python/prepare_binding_Python.py l

[Lldb-commits] [PATCH] D68007: [lldb] Move swig call from python code to cmake

hhb updated this revision to Diff 221664. hhb added a comment. Fix a typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68007/new/ https://reviews.llvm.org/D68007 Files: lldb/scripts/CMakeLists.txt lldb/scripts/Python/prepare_binding_Python.py

[Lldb-commits] [PATCH] D68007: [lldb] Move swig call from python code to cmake

hhb created this revision. hhb added reviewers: labath, mgorny. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Elimiates lots of unused code. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68007 Files: lldb/scripts/CMakeLists.txt lldb/scripts/Python