[Lldb-commits] [PATCH] D67942: Install python dll to bin

2019-09-24 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Looking at the history goes provide us with some clues. It seems it was done to ensure that during development launching lldb uses the same python dll that the lldb was built with. However, this was done in the days when one had to buil

[Lldb-commits] [PATCH] D67942: Install python dll to bin

2019-09-24 Thread Martin Storsjö via Phabricator via lldb-commits
mstorsjo added a comment. Sorry, I'm not familiar with how LLDB integrates with python and how all of that works on Windows, so I can't really comment on this one for now... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67942/new/ https://reviews.

[Lldb-commits] [PATCH] D67942: Install python dll to bin

2019-09-24 Thread Haibo Huang via Phabricator via lldb-commits
hhb marked an inline comment as done. hhb added a comment. Arguably a correct python installation in windows should already have python*.dll. But then why do we copy the file to build dir above. Comment at: lldb/CMakeLists.txt:233 COMMENT "Copying Python DLL to LL

[Lldb-commits] [PATCH] D67942: Install python dll to bin

2019-09-23 Thread Haibo Huang via Phabricator via lldb-commits
hhb created this revision. hhb added a reviewer: mstorsjo. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. Not sure whether this is a feature or bug... Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D67942 Files: lldb/CMakeLists.txt Index: lldb