This revision was automatically updated to reflect the committed changes.
Closed by commit rL372642: [ABISysV] Fix regression for Simulator and MacABI
(authored by JDevlieghere, committed by ).
Herald added subscribers: llvm-commits, fedor.sergeev.
Herald added a project: LLVM.
Changed prior to c
aprantl added inline comments.
Comment at: lldb/source/Plugins/ABI/SysV-x86_64/ABISysV_x86_64.cpp:231
+ case llvm::Triple::OSType::WatchOS:
+switch(os_env) {
+ case llvm::Triple::EnvironmentType::Simulator:
clang-format?
Repository:
rLLD
aprantl added a comment.
What does `x86_64-apple-darwin` canonicalize to? Do we need an extra case for
that?
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67869/new/
https://reviews.llvm.org/D67869
___
lldb-commit
aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.
Comment at: lldb/source/Plugins/ABI/SysV-x86_64/ABISysV_x86_64.cpp:233
+ case llvm::Triple::EnvironmentType::Simulator:
+ case llvm::Triple::Environme
JDevlieghere created this revision.
JDevlieghere added reviewers: aprantl, xiaobai.
Herald added a subscriber: abidh.
Herald added a project: LLDB.
The ABISysV ABI was refactored in r364216 to support the Windows ABI for
x86_64. In particular it changed `ABISysV_x86_64::CreateInstance` to switch
