[Lldb-commits] [PATCH] D67063: [lldb] Add description to option completions.

2019-09-02 Thread Raphael Isemann via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL370628: [lldb] Add description to option completions. (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revi

[Lldb-commits] [PATCH] D67063: [lldb] Add description to option completions.

2019-09-02 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. Good catch, extended the test to also test the ambiguous options. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67063/new/ https://reviews.llvm.org/D67063 ___ lldb-commits mailing list ll

[Lldb-commits] [PATCH] D67063: [lldb] Add description to option completions.

2019-09-02 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Sounds like a good idea. I noticed that you have three tests, but are changing four places in the code. Looks like you're probably missing one of them. By the looks of things, it's probably t

[Lldb-commits] [PATCH] D67063: [lldb] Add description to option completions.

2019-09-02 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor created this revision. teemperor added a reviewer: LLDB. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. Right now our argument completions are rather cryptic for command options as they only list the letters: (lldb) breakpoint set - Available co