This revision was automatically updated to reflect the committed changes.
Closed by commit rL368066: [lldb][CMake] Generating Xcode projects (authored by
stefan.graenitz, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://revi
jingham added a comment.
Thanks for doing this. Looks okay to me just one typo... But I don't know
CMake well enough to comment on substance...
Comment at: lldb/cmake/modules/LLDBConfig.cmake:78
+ "When building with Xcode, we recommend using the corresponding cache
sc
sgraenitz updated this revision to Diff 213637.
sgraenitz marked an inline comment as done.
sgraenitz added a comment.
Improve warning message
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65797/new/
https://reviews.llvm.org/D65797
Files:
lldb/c
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
Small comment about the working, but the change itself LGTM.
Comment at: lldb/cmake/modules/LLDBConfig.cmake:77
+message(WARNING
+ "When building with Xc
sgraenitz created this revision.
sgraenitz added reviewers: JDevlieghere, jingham, clayborg.
Herald added a subscriber: mgorny.
Herald added a project: LLDB.
Print a warning if the wrong cache script is used when generating a Xcode
project, because it's too easy to confuse with Apple-lldb-macOS.c
