[Lldb-commits] [PATCH] D65489: Format OptionEnumValueElement

2019-08-01 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL367638: Format OptionEnumValueElement (NFC) (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llv

[Lldb-commits] [PATCH] D65489: Format OptionEnumValueElement

2019-08-01 Thread Jim Ingham via Phabricator via lldb-commits
jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Okay, if clang-format won't undo this, then I'm fine with writing them this way. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65489/new/ https://reviews.llvm.org/D65489

[Lldb-commits] [PATCH] D65489: Format OptionEnumValueElement

2019-08-01 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. In D65489#1611165 , @jingham wrote: > What happens if you clang-format your reformatted version of the setter? Do > we need clang-format off for them? > > Otherwise this looks fine to me. This is the clang-format output!

[Lldb-commits] [PATCH] D65489: Format OptionEnumValueElement

2019-08-01 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. What happens if you clang-format your reformatted version of the setter? Do we need clang-format off for them? Otherwise this looks fine to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65489/new/ https://reviews.llvm.org/D65489 ___

[Lldb-commits] [PATCH] D65489: Format OptionEnumValueElement

2019-08-01 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere updated this revision to Diff 212892. JDevlieghere retitled this revision from "Tablegen option enum value elements" to "Format OptionEnumValueElement". JDevlieghere edited the summary of this revision. JDevlieghere added a reviewer: labath. JDevlieghere added a comment. Reformat Op