[Lldb-commits] [PATCH] D65271: Increase testsuite packet-timeout 5secs -> 5mins

jankratochvil updated this revision to Diff 211973. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65271/new/ https://reviews.llvm.org/D65271 Files: lldb/lit/lit-lldb-init.in lldb/packages/Python/lldbsuite/test/api/multithreaded/driver.cpp.template lldb/pa

[Lldb-commits] [PATCH] D65271: Increase testsuite packet-timeout 5secs -> 5mins

labath added a comment. In D65271#1601717 , @jankratochvil wrote: > In D65271#1600829 , @labath wrote: > > > Why not unify now? It shouldn't be too hard to at least unify all the > > instances in dotest python cod

[Lldb-commits] [PATCH] D65271: Increase testsuite packet-timeout 5secs -> 5mins

jankratochvil marked an inline comment as done. jankratochvil added a comment. In D65271#1600829 , @labath wrote: > Why not unify now? It shouldn't be too hard to at least unify all the > instances in dotest python code to a single place. That would alrea

[Lldb-commits] [PATCH] D65271: Increase testsuite packet-timeout 5secs -> 5mins

jankratochvil updated this revision to Diff 211825. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65271/new/ https://reviews.llvm.org/D65271 Files: lldb/lit/lit-lldb-init.in lldb/packages/Python/lldbsuite/test/api/multithreaded/driver.cpp.template lldb/pa

[Lldb-commits] [PATCH] D65271: Increase testsuite packet-timeout 5secs -> 5mins

jingham added a comment. There isn't an SB API for "settings set" yet. I've put off doing that because the "settings" subsystem is currently unfinished. In the original design you would be specify qualifiers in the setting hierarchy, like: settings set target[arch=x86_64].whatever That would

[Lldb-commits] [PATCH] D65271: Increase testsuite packet-timeout 5secs -> 5mins

labath added a comment. Why not unify now? It shouldn't be too hard to at least unify all the instances in dotest python code to a single place. That would already cut the number of places that need to be kept synced in half... Comment at: lldb/tools/lldb-test/lldb-test.cpp:9

[Lldb-commits] [PATCH] D65271: Increase testsuite packet-timeout 5secs -> 5mins

jankratochvil marked 3 inline comments as done. jankratochvil added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestNoWatchpointSupportInfo.py:24 return "T02thread:1ff0d;thread-pcs:10001bc00;" +

[Lldb-commits] [PATCH] D65271: Increase testsuite packet-timeout 5secs -> 5mins

jankratochvil updated this revision to Diff 211712. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65271/new/ https://reviews.llvm.org/D65271 Files: lldb/lit/lit-lldb-init.in lldb/packages/Python/lldbsuite/test/api/multithreaded/driver.cpp.template lldb/pa

[Lldb-commits] [PATCH] D65271: Increase testsuite packet-timeout 5secs -> 5mins

jankratochvil created this revision. jankratochvil added reviewers: aprantl, labath, clayborg. jankratochvil added a project: LLDB. Herald added subscribers: lldb-commits, abidh. rL357954 did increase `packet-timeout` 1sec -> 5secs. Which is IMO about the maxim