[Lldb-commits] [PATCH] D65163: Fix occasional hangs of VSCode testcases

2019-07-23 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil added a comment. One heisenbug down! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65163/new/ https://reviews.llvm.org/D65163 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.

[Lldb-commits] [PATCH] D65163: Fix occasional hangs of VSCode testcases

2019-07-23 Thread Jan Kratochvil via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL366850: [lldb] Fix occasional hangs of VSCode testcases (authored by jankratochvil, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:

[Lldb-commits] [PATCH] D65163: Fix occasional hangs of VSCode testcases

2019-07-23 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. In D65163#1597902 , @labath wrote: > Thank you very much for tracking this down. Maybe wait a while to see if > @clayborg has any thoughts on this, but otherwise, this looks good to me. haha, I already accepted. So good to go.

[Lldb-commits] [PATCH] D65163: Fix occasional hangs of VSCode testcases

2019-07-23 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. Thank you very much for tracking this down. Maybe wait a while to see if @clayborg has any thoughts on this, but otherwise, this looks good to me. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65163/new/ h

[Lldb-commits] [PATCH] D65163: Fix occasional hangs of VSCode testcases

2019-07-23 Thread Greg Clayton via Phabricator via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. If all tests pass, then I am good with this. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65163/new/ https://reviews.llvm.org/D65163

[Lldb-commits] [PATCH] D65163: Fix occasional hangs of VSCode testcases

2019-07-23 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil created this revision. jankratochvil added reviewers: clayborg, labath, stella.stamenova, gkistanova. jankratochvil added a project: LLDB. Herald added a reviewer: JDevlieghere. Herald added a subscriber: lldb-commits. On slower machines the vscode testcases were sometimes hanging: