[Lldb-commits] [PATCH] D64254: Add lldb-mi deprecation to the release notes

2019-07-08 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Random idea: Should we force the user to pass something like -DLLDB_TEMPORARILY_ENABLE_LLDB_MI to cmake to make sure it gets noticed that it is going away (I don't know how many people read release notes). And yeah, I should write something about type units in the releas

[Lldb-commits] [PATCH] D64254: Add lldb-mi deprecation to the release notes

2019-07-05 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL365231: Add lldb-mi deprecation to the release notes (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D64254?vs=208209&id=208214#toc Repository: rL LLVM C

[Lldb-commits] [PATCH] D64254: Add lldb-mi deprecation to the release notes

2019-07-05 Thread Davide Italiano via Phabricator via lldb-commits
davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64254/new/ https://reviews.llvm.org/D64254 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D64254: Add lldb-mi deprecation to the release notes

2019-07-05 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere updated this revision to Diff 208209. JDevlieghere added a comment. Move note into LLDB section. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64254/new/ https://reviews.llvm.org/D64254 Files: llvm/docs/ReleaseNotes.rst Index: llvm/docs/ReleaseNotes.rst ===

[Lldb-commits] [PATCH] D64254: Add lldb-mi deprecation to the release notes

2019-07-05 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. +1 Nit pick: I think in 8.0.0 we actually gave LLDB it's own small section: https://releases.llvm.org/8.0.0/docs/ReleaseNotes.html#changes-to-lldb I guess we have some other stuff we could add to that section that it is not just "removed lldb-mi". Repository: rL

[Lldb-commits] [PATCH] D64254: Add lldb-mi deprecation to the release notes

2019-07-05 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. JDevlieghere added a project: LLDB. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Mention that LLVM 9 is the last release we'll ship lldb-mi as part of LLDB. Repository: rL LLVM https://reviews.l