[Lldb-commits] [PATCH] D63813: Adjust variable formatting table

2019-07-17 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL366364: [docs] Adjust variable formatting table (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews

[Lldb-commits] [PATCH] D63813: Adjust variable formatting table

2019-07-17 Thread Lukas Böger via Phabricator via lldb-commits
lubgr updated this revision to Diff 210278. lubgr added a comment. I updated the description of the `address` format, is it appropriate? And I can't commit that myself, so thanks in advance for doing so when it's ready. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D63813: Adjust variable formatting table

2019-07-16 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. Lukas, do you have commit access or do you need one of us to land this for you? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63813/new/ https://reviews.llvm.org/D63813 ___ lldb-commit

[Lldb-commits] [PATCH] D63813: Adjust variable formatting table

2019-07-12 Thread Jim Ingham via Phabricator via lldb-commits
jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. That looks good. Note that the "address" format does more than show symbol/file/line offset, it will also print the string for addresses that point into the string pool. Might be worth men

[Lldb-commits] [PATCH] D63813: Adjust variable formatting table

2019-07-12 Thread Lukas Böger via Phabricator via lldb-commits
lubgr added a comment. Gentle ping... Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63813/new/ https://reviews.llvm.org/D63813 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[Lldb-commits] [PATCH] D63813: Adjust variable formatting table

2019-06-26 Thread Lukas Böger via Phabricator via lldb-commits
lubgr created this revision. lubgr added a reviewer: jingham. lubgr added a project: LLDB. Herald added subscribers: lldb-commits, abidh. While the in-place hints on valid formats are up to date (e.g. when choosing an invalid format `expr -f nonExisting -- 42`), the corresponding online docs tab