[Lldb-commits] [PATCH] D63370: Specify log level for CMake messages (less stderr)

This revision was automatically updated to reflect the committed changes. Closed by commit rL363821: Specify log level for CMake messages (less stderr) (authored by stefan.graenitz, committed by ). Herald added a subscriber: delcypher. Changed prior to commit: https://reviews.llvm.org/D63370?vs

[Lldb-commits] [PATCH] D63370: Specify log level for CMake messages (less stderr)

siedentop added a comment. @sgraenitz I cannot merge the changes myself, could you please commit them for me? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63370/new/ https://reviews.llvm.org/D63370 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D63370: Specify log level for CMake messages (less stderr)

siedentop updated this revision to Diff 205242. siedentop added a comment. @sgraenitz , good find. I've removed the leading dashes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63370/new/ https://reviews.llvm.org/D63370 Files: compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake

[Lldb-commits] [PATCH] D63370: Specify log level for CMake messages (less stderr)

sgraenitz added a comment. Thanks for the initiative! Three inline comments for cosmetics. Comment at: lldb/cmake/modules/LLDBConfig.cmake:143 PYTHONLIBS_VERSION_STRING "${python_version_str}") -message("-- Found Python version ${PYTHONLIBS_VERSION_STRING}") +

[Lldb-commits] [PATCH] D63370: Specify log level for CMake messages (less stderr)

siedentop updated this revision to Diff 204935. siedentop added a comment. Removed changes to `llvm/utils/benchmark`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63370/new/ https://reviews.llvm.org/D63370 Files: compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake lldb/cmake/mod

[Lldb-commits] [PATCH] D63370: Specify log level for CMake messages (less stderr)

lebedev.ri added a comment. In D63370#1544970 , @siedentop wrote: > In D63370#1544767 , @lebedev.ri > wrote: > > > The `llvm/utils/benchmark/` changes - can you please either submit them > > upstream yourself, or

[Lldb-commits] [PATCH] D63370: Specify log level for CMake messages (less stderr)

siedentop added a comment. In D63370#1544767 , @lebedev.ri wrote: > The `llvm/utils/benchmark/` changes - can you please either submit them > upstream yourself, or explicitly state that it is okay to **steal** them from > you and submit? Thanks, @lebed

[Lldb-commits] [PATCH] D63370: Specify log level for CMake messages (less stderr)

lebedev.ri added a comment. The `llvm/utils/benchmark/` changes - can you please either submit them upstream yourself, or explicitly state that it is okay to **steal** them from you and submit? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63370/new/ https://reviews.llvm.org/D63370

[Lldb-commits] [PATCH] D63370: Specify log level for CMake messages (less stderr)

siedentop marked an inline comment as done. siedentop added a comment. Thank you for the review, @xiaobai. I've made the requested change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63370/new/ https://reviews.llvm.org/D63370 ___ lldb-com

[Lldb-commits] [PATCH] D63370: Specify log level for CMake messages (less stderr)

siedentop updated this revision to Diff 204886. siedentop added a comment. Modified STATUS to WARNING as requested by @xiaobai CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63370/new/ https://reviews.llvm.org/D63370 Files: compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake lldb/

[Lldb-commits] [PATCH] D63370: Specify log level for CMake messages (less stderr)

xiaobai added a reviewer: sgraenitz. xiaobai added a comment. Seems alright to me. I'd like to see 1 message changed from a STATUS to a WARNING though. Comment at: lldb/cmake/modules/LLDBConfig.cmake:131 if ("${PYTHON_HOME}" STREQUAL "") -message("LLDB embedded Python o

[Lldb-commits] [PATCH] D63370: Specify log level for CMake messages (less stderr)

siedentop created this revision. siedentop added reviewers: zturner, beanz, xiaobai, kbobyrev. Herald added subscribers: llvm-commits, lldb-commits, Sanitizers, lebedev.ri, mgorny. Herald added a reviewer: lebedev.ri. Herald added projects: Sanitizers, LLDB, LLVM. Specify message levels in CMake.