[Lldb-commits] [PATCH] D62934: [LanguageRuntime] Introdce LLVM-style casts

This revision was automatically updated to reflect the committed changes. Closed by commit rL362884: [LanguageRuntime] Introduce LLVM-style casts (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews

[Lldb-commits] [PATCH] D62934: [LanguageRuntime] Introdce LLVM-style casts

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lgtm Comment at: source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp:1128 - RenderScriptRuntime *lang_rt = - (RenderScriptRuntime

[Lldb-commits] [PATCH] D62934: [LanguageRuntime] Introdce LLVM-style casts

xiaobai updated this revision to Diff 203420. xiaobai added a comment. Implement labath's suggestion CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62934/new/ https://reviews.llvm.org/D62934 Files: include/lldb/Target/CPPLanguageRuntime.h include/lldb/Target/LanguageRuntime.h incl

[Lldb-commits] [PATCH] D62934: [LanguageRuntime] Introdce LLVM-style casts

labath added a comment. Implementing `classof` via an enum is the simplest and most common solution, but it is not the only thing possible. The central enum thingy is fine when all the subclasses are also defined centrally, but for a more distributed scenario like this one, it begins to smell,

[Lldb-commits] [PATCH] D62934: [LanguageRuntime] Introdce LLVM-style casts

xiaobai created this revision. xiaobai added reviewers: labath, JDevlieghere. Herald added a subscriber: arphaman. Using llvm-style rtti gives us stronger guarantees around casting LanguageRuntimes. As discussed in D62755 https://reviews.llvm.org/D62934 Files: