[Lldb-commits] [PATCH] D62316: DWARFContext: Make loading of sections thread-safe

labath added a comment. In D62316#1515266 , @labath wrote: > In D62316#1513905 , @clayborg wrote: > > > In D62316#1513894 , @labath wrote: > > > > > Two other options I see a

[Lldb-commits] [PATCH] D62316: DWARFContext: Make loading of sections thread-safe

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB361602: DWARFContext: Make loading of sections thread-safe (authored by labath, committed by ). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D62316?vs=200970&id=201

[Lldb-commits] [PATCH] D62316: DWARFContext: Make loading of sections thread-safe

labath marked an inline comment as done. labath added a comment. In D62316#1513905 , @clayborg wrote: > In D62316#1513894 , @labath wrote: > > > Two other options I see are: > > > > - initialize the sections immedia

[Lldb-commits] [PATCH] D62316: DWARFContext: Make loading of sections thread-safe

clayborg added a comment. In D62316#1513894 , @labath wrote: > Two other options I see are: > > - initialize the sections immediately after creating the dwarf context. The > main advantage of that would that it alings to code more with llvm (which > also

[Lldb-commits] [PATCH] D62316: DWARFContext: Make loading of sections thread-safe

clayborg accepted this revision. clayborg added inline comments. This revision is now accepted and ready to land. Comment at: source/Plugins/SymbolFile/DWARF/DWARFContext.h:25 + struct SectionData { +llvm::once_flag flag; +DWARFDataExtractor data; is llv

[Lldb-commits] [PATCH] D62316: DWARFContext: Make loading of sections thread-safe

labath added a comment. Two other options I see are: - initialize the sections immediately after creating the dwarf context. The main advantage of that would that it alings to code more with llvm (which also loads the sections up-front), and slighly faster subsequent accesses to the debug info

[Lldb-commits] [PATCH] D62316: DWARFContext: Make loading of sections thread-safe

labath created this revision. labath added reviewers: aprantl, JDevlieghere, clayborg. Herald added a subscriber: arphaman. SymbolFileDWARF used to load debug sections in a thread-safe manner. When we moved to DWARFContext, we dropped the thread-safe part, because we thought it was not necessary.