[Lldb-commits] [PATCH] D62273: Expression: correct relocation model for Windows

2019-05-22 Thread Saleem Abdulrasool via Phabricator via lldb-commits
compnerd closed this revision. compnerd added a comment. SVN r361443 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62273/new/ https://reviews.llvm.org/D62273 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [PATCH] D62273: Expression: correct relocation model for Windows

2019-05-22 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. I don't know much about this, but the change seems reasonable. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62273/new/ https://reviews.llvm.org/

[Lldb-commits] [PATCH] D62273: Expression: correct relocation model for Windows

2019-05-22 Thread Saleem Abdulrasool via Phabricator via lldb-commits
compnerd created this revision. compnerd added reviewers: aprantl, JDevlieghere, labath, clayborg, xiaobai, davide. Herald added a project: LLDB. The Windows CG model cannot generate code with the PIC relocation model as all code is implicitly PIC. Invert the condition and inline the single use