Re: [Lldb-commits] [PATCH] D62221: [lldb-server][LLGS] Support 'g' packets

Thank you for the suggestion, Jason! The feature is like this https://docs.microsoft.com/en-us/visualstudio/debugger/how-to-use-the-registers-window?view=vs-2019 - the user can select the register sets they want to see. There's an extra complication, though. I am using the C++ API, so I actually ge

[Lldb-commits] [PATCH] D62221: [lldb-server][LLGS] Support 'g' packets

This revision was automatically updated to reflect the committed changes. Closed by commit rL362063: [lldb-server] Support 'g' packets (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D6

[Lldb-commits] [PATCH] D62221: [lldb-server][LLGS] Support 'g' packets

guiandrade added a comment. In D62221#1520586 , @labath wrote: > BTW, do you have commit access, or you need someone to commit this for you? I do not, I would need someone to help me commit that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[Lldb-commits] [PATCH] D62221: [lldb-server][LLGS] Support 'g' packets

labath added a comment. BTW, do you have commit access, or you need someone to commit this for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62221/new/ https://reviews.llvm.org/D62221 ___ lldb-com

[Lldb-commits] [PATCH] D62221: [lldb-server][LLGS] Support 'g' packets

guiandrade updated this revision to Diff 201790. guiandrade added a comment. Remove redundant cast from GDBRemoteCommunicationServerLLGS::Handle_g and add annotation to TestGdbRemoteGPacket::g_returns_correct_data so it gets skipped if the running architecture isn't x86_64 Repository: rG LL

[Lldb-commits] [PATCH] D62221: [lldb-server][LLGS] Support 'g' packets

labath added a subscriber: omjavaid. labath added a comment. I have a couple of comments inline, but overall I think this looks pretty good now. It would be interesting to also test reading %ymm registers, as those are stored in a funny way in the cpu context (and so we are most likely to get t

[Lldb-commits] [PATCH] D62221: [lldb-server][LLGS] Support 'g' packets

guiandrade updated this revision to Diff 201583. guiandrade added a comment. Add inferior to to set the values of a few registers to known values so we can verify the 'g' packet looks good. Also, start testing with/without thread suffix . Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[Lldb-commits] [PATCH] D62221: [lldb-server][LLGS] Support 'g' packets

labath added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-server/TestLldbGdbServer.py:585 + +def g_returns_correct_data(self): +procs = self.prep_debug_monitor_and_inferior() guiandrade wrote: > @labath, is it something

Re: [Lldb-commits] [PATCH] D62221: [lldb-server][LLGS] Support 'g' packets

If the remote serial protocol stub includes the GPR register values in the stop packet / jThreadsInfo packet, lldb will pre-seed the thread's RegisterContext with these values. So if the user asks for rax, lldb will already have rax for instance. debugserver doesn't send the vector/floating poin

[Lldb-commits] [PATCH] D62221: [lldb-server][LLGS] Support 'g' packets

jasonmolenda added a comment. Does your feature print *all* the registers including floating point/vector registers? Or just the main general purpose registers? In debugserver, we expedite the register values for the stopping thread: 1558572448.355979919 < 624> read packet: $T05thread:3ef471

[Lldb-commits] [PATCH] D62221: [lldb-server][LLGS] Support 'g' packets

guiandrade added a comment. Thank you so much for the feedback! In D62221#1511035 , @clayborg wrote: > Using 'g' packets seems fine to me and we might be able to just enable it. We > will need to ensure that this doesn't regress stepping times so we will

[Lldb-commits] [PATCH] D62221: [lldb-server][LLGS] Support 'g' packets

guiandrade updated this revision to Diff 200846. guiandrade marked an inline comment as done. guiandrade edited the summary of this revision. guiandrade added a comment. Making this revision be responsible only for adding the 'g' packet handler and tests. Also, I'm starting to implement a stronge

[Lldb-commits] [PATCH] D62221: [lldb-server][LLGS] Support 'g' packets

labath added a subscriber: mgorny. labath added a comment. I think it would be good to split this patch into two: - implementing `g` packet in lldb-server - deciding when lldb sends the `g` packet For the first part, I don't see any reason why lldb-server should *not* support the `g` packet. T

[Lldb-commits] [PATCH] D62221: [lldb-server][LLGS] Support 'g' packets

jasonmolenda added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ThreadGDBRemote.cpp:307-316 +#ifdef LLDB_REMOTE_SHOULD_READ_ALL_REGISTERS_AT_ONCE + // Always fetch the registers at once when the flag has been defined. + bool read_all_registers_at_

[Lldb-commits] [PATCH] D62221: [lldb-server][LLGS] Support 'g' packets

clayborg added a comment. Using 'g' packets seems fine to me and we might be able to just enable it. We will need to ensure that this doesn't regress stepping times so we will need to get people to try this out on their systems first. Most of our targets expedite enough registers in the stop re

[Lldb-commits] [PATCH] D62221: [lldb-server][LLGS] Support 'g' packets

guiandrade created this revision. guiandrade added a reviewer: labath. guiandrade added a project: LLDB. Herald added a subscriber: lldb-commits. This change makes it possible to fetch all registers at once from Linux by defining a macro. This is useful for the case when all registers are being f