[Lldb-commits] [PATCH] D61994: [CommandInterpreter] Refactor SourceInitFile

This revision was automatically updated to reflect the committed changes. Closed by commit rL361080: [CommandInterpreter] Refactor SourceInitFile (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://re

[Lldb-commits] [PATCH] D61994: [CommandInterpreter] Refactor SourceInitFile

JDevlieghere updated this revision to Diff 200056. JDevlieghere added a comment. Remove unneeded use of FileSpec. I wanted to do this yesterday but didn't get around to it... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61994/new/ https://reviews.llvm.org/D61994 Files: lldb/include

[Lldb-commits] [PATCH] D61994: [CommandInterpreter] Refactor SourceInitFile

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I think this looks better than the original. Given that the only callers of `SourceInitFile` pass a constant value for the `InitFileLocation` argument, what I'd consider also doing is getting

[Lldb-commits] [PATCH] D61994: [CommandInterpreter] Refactor SourceInitFile

JDevlieghere updated this revision to Diff 199943. JDevlieghere added a comment. Address code review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61994/new/ https://reviews.llvm.org/D61994 Files: lldb/include/lldb/Interpreter/CommandInterpreter.h lldb/source/API/SBCommand

[Lldb-commits] [PATCH] D61994: [CommandInterpreter] Refactor SourceInitFile

xiaobai added a comment. Seems like an overall improvement to the structure of this code. At the high level, the structure feels easier to understand. In D61994#1504336 , @labath wrote: > I think this is a bit more readable. I've included some suggestion

[Lldb-commits] [PATCH] D61994: [CommandInterpreter] Refactor SourceInitFile

labath added a comment. I think this is a bit more readable. I've included some suggestions which I think could make it even better. Since you're already rewriting this code, this might be a good time to raise a point I wanted to bring up some day. Should we be using `FileSpec` for code like t

[Lldb-commits] [PATCH] D61994: [CommandInterpreter] Refactor SourceInitFile

JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:2118 +void CommandInterpreter::SourceInitFile(FileSpec file, CommandReturnObject &result) { + if

[Lldb-commits] [PATCH] D61994: [CommandInterpreter] Refactor SourceInitFile

JDevlieghere created this revision. JDevlieghere added reviewers: labath, xiaobai, jingham. Herald added a project: LLDB. JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:2118 +void Comma