This revision was automatically updated to reflect the committed changes.
Closed by commit rL360908: Minidump: Add support for the MemoryList stream
(authored by labath, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D61885?vs=199570&id=199837#toc
Repository:
rL LLVM
CHAN
labath added a comment.
Thanks. This is very straight-forward, so I don't think another set of eyes is
needed (though I expect Greg is keeping at least one eye on this).
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61885/new/
https://reviews.llvm.org/D61885
_
jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.
LGTM, though I haven't bothered to inspect the detail of the minidump format.
I'll leave it up to you whether you think it's worth getting a separate pair of
eyes.
labath updated this revision to Diff 199570.
labath marked 6 inline comments as done.
labath added a comment.
Address review comments.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61885/new/
https://reviews.llvm.org/D61885
Files:
include/llvm/Object/Minidump.h
labath added inline comments.
Comment at: include/llvm/Object/Minidump.h:85-86
+ /// error is returned if the file does not contain this stream, or if the
+ /// stream is not large enough to contain the number of threads declared in
+ /// the stream header. The consistency of
jhenderson added inline comments.
Comment at: include/llvm/Object/Minidump.h:85-86
+ /// error is returned if the file does not contain this stream, or if the
+ /// stream is not large enough to contain the number of threads declared in
+ /// the stream header. The consistency
labath created this revision.
labath added reviewers: amccarth, jhenderson, clayborg.
Herald added a project: LLVM.
the stream format is exactly the same as for ThreadList and ModuleList
streams, only the entry types are slightly different, so the changes in
this patch are just straight-forward ap
