[Lldb-commits] [PATCH] D61864: Merge target and launch info environments

2019-05-13 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB360612: Merge target and launch info environments (authored by JDevlieghere, committed by ). Herald added a subscriber: teemperor. Changed prior to commit: https://reviews.llvm.org/D61864?vs=199294&i

[Lldb-commits] [PATCH] D61864: Merge target and launch info environments

2019-05-13 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. The fix looks good, but it seems like it wouldn't be hard to make the test windows-compatible, so I think we should do that. All it would take is to compile a very dumb version of "env" which

[Lldb-commits] [PATCH] D61864: Merge target and launch info environments

2019-05-13 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere created this revision. JDevlieghere added reviewers: labath, aprantl, davide. Herald added a project: LLDB. Before this change we were overriding the launch info environment with the target environment. This meant that the environment variables passed to `process launch --environmen