labath marked an inline comment as done.
labath added inline comments.
Comment at: include/lldb/Symbol/FuncUnwinders.h:117
+ class LazyPlan {
+lldb::UnwindPlanSP m_plan_sp;
+
clayborg wrote:
> clayborg wrote:
> > labath wrote:
> > > clayborg wrote:
> > > > m
clayborg added inline comments.
Comment at: include/lldb/Symbol/FuncUnwinders.h:117
+ class LazyPlan {
+lldb::UnwindPlanSP m_plan_sp;
+
clayborg wrote:
> labath wrote:
> > clayborg wrote:
> > > maybe use:
> > >
> > > ```
> > > llvm::Optional m_plan_sp;
> >
clayborg added inline comments.
Comment at: include/lldb/Symbol/FuncUnwinders.h:117
+ class LazyPlan {
+lldb::UnwindPlanSP m_plan_sp;
+
labath wrote:
> clayborg wrote:
> > maybe use:
> >
> > ```
> > llvm::Optional m_plan_sp;
> > ```
> >
> > Then just check
labath marked an inline comment as done.
labath added inline comments.
Comment at: include/lldb/Symbol/FuncUnwinders.h:117
+ class LazyPlan {
+lldb::UnwindPlanSP m_plan_sp;
+
clayborg wrote:
> maybe use:
>
> ```
> llvm::Optional m_plan_sp;
> ```
>
> Then j
clayborg added inline comments.
Comment at: include/lldb/Symbol/FuncUnwinders.h:117
+ class LazyPlan {
+lldb::UnwindPlanSP m_plan_sp;
+
maybe use:
```
llvm::Optional m_plan_sp;
```
Then just check if it has no value, and if so compute and set it either to
labath created this revision.
labath added reviewers: jasonmolenda, clayborg.
A large chunk of this file was dealing with the caching of unwind plans.
In this patch I create a helper class to encapsulate this behavior and
leave the functions to deal with the actual work, which is to compute
the ac
