[Lldb-commits] [PATCH] D61776: [Target] Generalize some behavior in Thread

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB360741: [Target] Generalize some behavior in Thread (authored by xiaobai, committed by ). Herald added a subscriber: teemperor. Herald added a project: LLDB. Changed prior to commit: https://reviews.

[Lldb-commits] [PATCH] D61776: [Target] Generalize some behavior in Thread

xiaobai updated this revision to Diff 199364. xiaobai added a comment. - Fix minor bug in ItaniumABILanguageRuntime - Modify test to accomodate new behavior CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61776/new/ https://reviews.llvm.org/D61776 Files: packages/Python/lldbsuite/test/

[Lldb-commits] [PATCH] D61776: [Target] Generalize some behavior in Thread

xiaobai added a comment. Unfortunately I can't land this patch as-is. With this patch applied, TestObjCExceptions fails. It looks like c++ exceptions are supported at the bare minimum as a part of the objc exception handling logic. It was failing 2 subtests: `test_objc_exceptions_at_throw` and

[Lldb-commits] [PATCH] D61776: [Target] Generalize some behavior in Thread

xiaobai updated this revision to Diff 199048. xiaobai added a comment. Add comments to give better context CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61776/new/ https://reviews.llvm.org/D61776 Files: source/Target/Thread.cpp Index: source/Target/Thread.cpp ==

[Lldb-commits] [PATCH] D61776: [Target] Generalize some behavior in Thread

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. With appropriate comments, this seems fine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61776/new/ https://reviews.llvm.org/D61776 _

[Lldb-commits] [PATCH] D61776: [Target] Generalize some behavior in Thread

xiaobai added a comment. In D61776#1498225 , @jingham wrote: > If you really are going to support many languages you need to figure out how > to tell folks what really happened with more specificity. I agree. > For instance, you can use C++ to throw an

[Lldb-commits] [PATCH] D61776: [Target] Generalize some behavior in Thread

jingham added a comment. If you really are going to support many languages you need to figure out how to tell folks what really happened with more specificity. For instance, you can use C++ to throw anything, so you could throw an ObjC object from a C++ exception throw. So you need to disting

[Lldb-commits] [PATCH] D61776: [Target] Generalize some behavior in Thread

xiaobai created this revision. xiaobai added reviewers: davide, JDevlieghere, jingham, kubamracek, clayborg. I don't think there's a good reason for this behavior to be considered ObjC-specific. We can generalize this. https://reviews.llvm.org/D61776 Files: source/Target/Thread.cpp Index: s