This revision was automatically updated to reflect the committed changes.
Closed by commit rL360509: [Breakpoint] Make breakpoint language agnostic
(authored by xiaobai, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
CHANGES SINCE LAS
xiaobai updated this revision to Diff 199113.
xiaobai added a comment.
- Fix minor bug
- Return vector by value instead of passing in one by parameter.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61746/new/
https://reviews.llvm.org/D61746
Files:
include/lldb/Target/Language.h
sou
labath added inline comments.
Comment at: include/lldb/Target/Language.h:198
+ GetMethodNameVariants(ConstString method_name,
+std::vector &variant_names) const {
+return;
Return the vector by value ?
CHANGES SINCE LAST ACTION
htt
xiaobai updated this revision to Diff 198911.
xiaobai added a comment.
Rework function
GetVariantMethodNames -> GetMethodNameVariants
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61746/new/
https://reviews.llvm.org/D61746
Files:
include/lldb/Target/Language.h
source/Breakpoint/Bre
xiaobai added a comment.
Thanks for the feedback!
I don't quite feel that "Method" is a great descriptor here either, but I think
that it's probably fine for now until we can think of a better name. I'll
update this when I get the chance.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
That looks fine, thanks for untangling this.
I do like Jonas' suggestion better. GetVariantMethodNames sounds like
"VariantMethods" are a specific thing and you are trying to find their nam
JDevlieghere added inline comments.
Comment at: include/lldb/Target/Language.h:197
+ virtual void
+ GetVariantMethodNames(ConstString method_name,
+std::vector &variant_names) const {
GetMethodNameVariants?
Comment at
xiaobai created this revision.
xiaobai added reviewers: JDevlieghere, jingham, clayborg.
Herald added a subscriber: mgorny.
Breakpoint shouldn't need to depend on any specific details from a
programming language. Currently the only language-specific detail it takes
advantage of are the different q
