This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL368776: Update Python tests for lldb-server on Windows
(authored by asmith, committed by ).
Herald added a project: LLVM.
asmith added a comment.
Any more comments on the tests for Windows?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61687/new/
https://reviews.llvm.org/D61687
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cg
asmith updated this revision to Diff 214985.
asmith edited the summary of this revision.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61687/new/
https://reviews.llvm.org/D61687
Files:
packages/Python/lldbsuite/test/dotest.py
packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRe
labath accepted this revision.
labath added a comment.
Ok, let's give this a shot.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61687/new/
https://reviews.llvm.org/D61687
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://li
asmith updated this revision to Diff 200160.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61687/new/
https://reviews.llvm.org/D61687
Files:
packages/Python/lldbsuite/test/dotest.py
packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemoteAuxvSupport.py
packages/Python/lldbsui
labath added a comment.
Thanks for explaining. I think this is good to go, sans the merging of the two
tests I requested, and the comment fix that @clayborg noticed.
Comment at:
packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemoteThreadsInStopReply.py:208-212
+#
Hui added inline comments.
Comment at:
packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemoteThreadsInStopReply.py:208-212
+# In current implementation of llgs on Windows, as a response to '\x03'
packet, the debugger
+# of the native process will trigger a call
Hui added inline comments.
Comment at:
packages/Python/lldbsuite/test/tools/lldb-server/inferior-crash/TestGdbRemoteAbort.py:40
+@skipIfWindows # For now the signo in T* packet is always 0.
@llgs_test
labath wrote:
> labath wrote:
> > Do you have any
clayborg added inline comments.
Comment at: packages/Python/lldbsuite/test/dotest.py:1313
# Don't do lldb-server (llgs) tests on anything except Linux.
+configuration.dont_do_llgs_test = not ("linux" in target_platform) and not
("windows" in target_platform)
-
labath added inline comments.
Comment at:
packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemoteProcessInfo.py:205-217
@skipUnlessPlatform(["linux"])
@llgs_test
def test_qProcessInfo_does_not_contain_cputype_cpusubtype_llgs_linux(self):
self.init_
asmith updated this revision to Diff 199554.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61687/new/
https://reviews.llvm.org/D61687
Files:
packages/Python/lldbsuite/test/dotest.py
packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemoteAuxvSupport.py
packages/Python/lldbsui
labath added inline comments.
Comment at:
packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemoteModuleInfo.py:24-27
+# Replace path separators in the json string either with "" or "/"
on Windows.
+triple = self.dbg.GetSelectedPlatform().GetTriple()
+
Hui added inline comments.
Comment at:
packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemoteModuleInfo.py:24-27
+# Replace path separators in the json string either with "" or "/"
on Windows.
+triple = self.dbg.GetSelectedPlatform().GetTriple()
+
clayborg requested changes to this revision.
clayborg added inline comments.
This revision now requires changes to proceed.
Comment at:
packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemoteKill.py:17
def attach_commandline_kill_after_initial_stop(self):
+re
labath added inline comments.
Herald added a subscriber: dexonsmith.
Comment at:
packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemoteKill.py:17-23
+reg_expr = r"^\$X[0-9a-fA-F]+([^#]*)#[0-9A-Fa-f]{2}"
+triple = self.dbg.GetSelectedPlatform().GetTriple()
asmith created this revision.
asmith added reviewers: labath, rnk.
Herald added a reviewer: jfb.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D61687
Files:
packages/Python/lldbsuite/test/dotest.py
packages/Python/lld
16 matches
Mail list logo