[Lldb-commits] [PATCH] D61501: 02/06: Finish renaming CompileUnit->Unit

jankratochvil added a comment. Thanks for the review, I have pushed it ahead of the rest of the series as it was a bit annoying to keep it updating off-trunk. And then the renaming is a correct cleanup anyway. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61501/n

[Lldb-commits] [PATCH] D61501: 02/06: Finish renaming CompileUnit->Unit

This revision was automatically updated to reflect the committed changes. Closed by commit rL360443: Finish renaming CompileUnit -> Unit (authored by jankratochvil, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

[Lldb-commits] [PATCH] D61501: 02/06: Finish renaming CompileUnit->Unit

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM with Pavel's comment addressed. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61501/new/ https://reviews.llvm.org/D61501 ___ lldb-commits mail

[Lldb-commits] [PATCH] D61501: 02/06: Finish renaming CompileUnit->Unit

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1767 DWARFUnit *dwarf_cu = -debug_info->GetCompileUnit(cu_offset, &cu_idx); +

[Lldb-commits] [PATCH] D61501: 02/06: Finish renaming CompileUnit->Unit

jankratochvil created this revision. jankratochvil added reviewers: clayborg, labath, JDevlieghere. jankratochvil added a project: LLDB. Herald added subscribers: lldb-commits, jdoerfert, abidh, arphaman, aprantl. D42892 changed a lot of code to use superclass `D