This revision was automatically updated to reflect the committed changes.
labath marked an inline comment as done.
Closed by commit rLLDB360014: [DWARF] Reimplement/simplify DWARFUnit::GetID
(authored by labath, committed by ).
Herald added a subscriber: abidh.
Herald added a project: LLDB.
Chang
labath marked 2 inline comments as done.
labath added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h:43
size_t GetNumCompileUnits();
DWARFUnit *GetCompileUnitAtIndex(uint32_t idx);
+ DWARFUnit *GetCompileUnitAtOffset(dw_offset_t cu_offset,
--
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM with one inline comment.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h:43
size_t GetNumCompileUnits();
DWARFUnit *GetCompileUnitAtIndex(
labath created this revision.
labath added reviewers: JDevlieghere, clayborg, aprantl.
Herald added subscribers: jdoerfert, arphaman.
The implementation of GetID used a relatively complicated algorithm,
which returned some kind of an offset of the unit in some file
(depending on the debug info fla
