teemperor abandoned this revision.
teemperor added a comment.
Herald added a subscriber: JDevlieghere.
This is no longer necessary as we abandon the "reimplement include directories"
approach (we now look at the support files or require -gmodules which both
provide the same information in a more
aprantl added inline comments.
Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp:244
+ case lldb::eLanguageTypeObjC_plus_plus:
+return {sys_root + "/usr/include/"};
+ default:
aprantl wrote:
> I'm not 100% sure if that is how Clang header s
aprantl added inline comments.
Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp:244
+ case lldb::eLanguageTypeObjC_plus_plus:
+return {sys_root + "/usr/include/"};
+ default:
aprantl wrote:
> aprantl wrote:
> > I'm not 100% sure if that is
aprantl added inline comments.
Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp:244
+ case lldb::eLanguageTypeObjC_plus_plus:
+return {sys_root + "/usr/include/"};
+ default:
I'm not 100% sure if that is how Clang header search works, but
teemperor created this revision.
teemperor added a reviewer: aprantl.
Herald added subscribers: lldb-commits, abidh.
Herald added a project: LLDB.
`GetSystemIncludeDirectories` is currently only implemented for Linux where it
returns `/usr/include` with a potential sysroot
as a prefix. This patch
