[Lldb-commits] [PATCH] D61235: Add more information to the log timer dump

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL361987: Add more information to the log timer dump (authored by aadsm, committed by ). Herald added a project: LLVM. Heral

[Lldb-commits] [PATCH] D61235: Add more information to the log timer dump

aadsm updated this revision to Diff 201349. aadsm added a comment. Rebase and fixed an issue with one of the asserts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61235/new/ https://reviews.llvm.org/D61235 Files: lldb/include/lldb/Utility/Timer

[Lldb-commits] [PATCH] D61235: Add more information to the log timer dump

aadsm updated this revision to Diff 198116. aadsm added a comment. Undo the previous changes because I updated to the wrong diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61235/new/ https://reviews.llvm.org/D61235 Files: lldb/include/lldb/U

[Lldb-commits] [PATCH] D61235: Add more information to the log timer dump

aadsm updated this revision to Diff 198114. aadsm added a comment. Herald added subscribers: jdoerfert, MaskRay, eraman, arichardson, mgorny, emaste. Herald added a reviewer: espindola. - Renamed CompareFileAndLine to FileAndLineEqual and made it return a bool - Made include_inlined_functions a m

[Lldb-commits] [PATCH] D61235: Add more information to the log timer dump

aadsm updated this revision to Diff 197420. aadsm added a comment. Use EXPECT_NEAR for tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61235/new/ https://reviews.llvm.org/D61235 Files: lldb/include/lldb/Utility/Timer.h lldb/source/Utility/

[Lldb-commits] [PATCH] D61235: Add more information to the log timer dump

labath added inline comments. Comment at: lldb/unittests/Utility/TimerTest.cpp:100-101 + << "String: " << ss.GetData(); + EXPECT_GT(total1 - child1, seconds1 - 0.001); + EXPECT_LT(total1 - child1, seconds1 + 0.001); + EXPECT_EQ(1, count1); aadsm wrote: >

[Lldb-commits] [PATCH] D61235: Add more information to the log timer dump

aadsm updated this revision to Diff 197246. aadsm added a comment. Only store needed data for dumping and put everything in the struct. Also fix tests to do sequential calls instead of recursive. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61235/

[Lldb-commits] [PATCH] D61235: Add more information to the log timer dump

aadsm marked an inline comment as done. aadsm added inline comments. Comment at: lldb/unittests/Utility/TimerTest.cpp:100-101 + << "String: " << ss.GetData(); + EXPECT_GT(total1 - child1, seconds1 - 0.001); + EXPECT_LT(total1 - child1, seconds1 + 0.001); + EXPECT_EQ(1, co

[Lldb-commits] [PATCH] D61235: Add more information to the log timer dump

aadsm planned changes to this revision. aadsm marked 2 inline comments as done. aadsm added inline comments. Comment at: lldb/source/Utility/Timer.cpp:110-123 +namespace { +struct Stats { + uint64_t nanos; + uint64_t nanos_total; + uint64_t nanos_child; + uint64_t count; +};

[Lldb-commits] [PATCH] D61235: Add more information to the log timer dump

labath added inline comments. Comment at: lldb/source/Utility/Timer.cpp:98-101 m_category.m_nanos += std::chrono::nanoseconds(timer_dur).count(); + m_category.m_nanos_total += std::chrono::nanoseconds(total_dur).count(); + m_category.m_nanos_child += + std::chrono::nano

[Lldb-commits] [PATCH] D61235: Add more information to the log timer dump

aadsm marked an inline comment as done. aadsm added inline comments. Comment at: lldb/unittests/Utility/TimerTest.cpp:100-101 + << "String: " << ss.GetData(); + EXPECT_GT(total1 - child1, seconds1 - 0.001); + EXPECT_LT(total1 - child1, seconds1 + 0.001); + EXPECT_EQ(1, co

[Lldb-commits] [PATCH] D61235: Add more information to the log timer dump

davide added inline comments. Comment at: lldb/unittests/Utility/TimerTest.cpp:100-101 + << "String: " << ss.GetData(); + EXPECT_GT(total1 - child1, seconds1 - 0.001); + EXPECT_LT(total1 - child1, seconds1 + 0.001); + EXPECT_EQ(1, count1); this seems ...

[Lldb-commits] [PATCH] D61235: Add more information to the log timer dump

aadsm updated this revision to Diff 197049. aadsm added a comment. Move struct to anonymous namespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61235/new/ https://reviews.llvm.org/D61235 Files: lldb/include/lldb/Utility/Timer.h lldb/source

[Lldb-commits] [PATCH] D61235: Add more information to the log timer dump

aadsm updated this revision to Diff 197048. aadsm added a comment. Fix and add unit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61235/new/ https://reviews.llvm.org/D61235 Files: lldb/include/lldb/Utility/Timer.h lldb/source/Utility/Time

[Lldb-commits] [PATCH] D61235: Add more information to the log timer dump

teemperor added a comment. Could you provide a test? There are some existing tests for Timer in `lldb/unittests/Utility/TimerTest.cpp` which you can extend. You can run/compile these tests via `LIT_FILTER="TimerTest" make check-lldb`. (I also believe this patch breaks `TimerTest` as it checks t

[Lldb-commits] [PATCH] D61235: Add more information to the log timer dump

aadsm created this revision. aadsm added a reviewer: clayborg. Herald added subscribers: lldb-commits, abidh, jfb, erik.pilkington, aprantl. Herald added a project: LLDB. The `log timer dump` is showing the time of the function itself minus any function that is called from this one that also happ