[Lldb-commits] [PATCH] D61233: Refactor ObjectFile::GetSDKVersion

This revision was automatically updated to reflect the committed changes. Closed by commit rL365090: Refactor ObjectFile::GetSDKVersion (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.or

[Lldb-commits] [PATCH] D61233: Refactor ObjectFile::GetSDKVersion

labath added a comment. looks good to me too... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61233/new/ https://reviews.llvm.org/D61233 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[Lldb-commits] [PATCH] D61233: Refactor ObjectFile::GetSDKVersion

clayborg added a comment. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61233/new/ https://reviews.llvm.org/D61233 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D61233: Refactor ObjectFile::GetSDKVersion

teemperor updated this revision to Diff 206451. teemperor added a comment. - Rewrote patch to use llvm::VersionTuple (thanks Pavel) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61233/new/ https://reviews.llvm.org/D61233 Files: lldb/include/lldb/Symbol/ObjectFile.h lldb/source/Plug

[Lldb-commits] [PATCH] D61233: Refactor ObjectFile::GetSDKVersion

teemperor marked an inline comment as done. teemperor added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp:211 "SDKs/MacOSX%u.%u.sdk", - xcode_contents_path.c_str(), versions[0], -

[Lldb-commits] [PATCH] D61233: Refactor ObjectFile::GetSDKVersion

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Awesome. I should have done that right away. This isn't super important, but I feel like just returning a vector (with potentially zero elements would be just as good) and the Optional doesn

[Lldb-commits] [PATCH] D61233: Refactor ObjectFile::GetSDKVersion

labath added a comment. In D61233#1481527 , @teemperor wrote: > I decided to go for a vector because otherwise the implementation in > ObjectFileMachO gets a bit awkward. But I have no problem with doing a > VersionTuple instead and adding some manual tr

[Lldb-commits] [PATCH] D61233: Refactor ObjectFile::GetSDKVersion

teemperor added a comment. I decided to go for a vector because otherwise the implementation in ObjectFileMachO gets a bit awkward. But I have no problem with doing a VersionTuple instead and adding some manual translation to version tuple in ObjectFileMachO. CHANGES SINCE LAST ACTION https

[Lldb-commits] [PATCH] D61233: Refactor ObjectFile::GetSDKVersion

teemperor created this revision. teemperor added reviewers: aprantl, jasonmolenda. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch modernizes the GetSDKVersion API and hopefully prevents problems such as the ones discovered in D61218

[Lldb-commits] [PATCH] D61233: Refactor ObjectFile::GetSDKVersion

teemperor updated this revision to Diff 196987. teemperor added a comment. - Added documentation on the return value. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61233/new/ https://reviews.llvm.org/D61233 Files: lldb/include/lldb/Symbol/ObjectFile.h lldb/source/Plugins/ObjectFile