[Lldb-commits] [PATCH] D61191: Editline: Fix an msan error

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB359449: Editline: Fix an msan error (authored by labath, committed by ). Herald added a subscriber: abidh. Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D61191?vs=19

Re: [Lldb-commits] [PATCH] D61191: Editline: Fix an msan error

Yes, you don't need to NULL terminate the argument list now. Here's a link to the commit: http://mail-index.netbsd.org/source-changes/2019/04/26/msg105454.html Best, christos > On Apr 29, 2019, at 7:39 AM, Pavel Labath wro

Re: [Lldb-commits] [PATCH] D61191: Editline: Fix an msan error

On 26/04/2019 18:56, Christos Zoulas wrote: On Apr 26, 3:11pm, revi...@reviews.llvm.org (Pavel Labath via Phabricator) wrote: -- Subject: [PATCH] D61191: Editline: Fix an msan error | | --b1_b299efcc557883c5ff30a5eebc16e12b | Content-Type: text/plain; charset=us-ascii | Content-Transfer-Encodi

Re: [Lldb-commits] [PATCH] D61191: Editline: Fix an msan error

On Apr 26, 3:11pm, revi...@reviews.llvm.org (Pavel Labath via Phabricator) wrote: -- Subject: [PATCH] D61191: Editline: Fix an msan error | | --b1_b299efcc557883c5ff30a5eebc16e12b | Content-Type: text/plain; charset=us-ascii | Content-Transfer-Encoding: quoted-printable | | labath created this

[Lldb-commits] [PATCH] D61191: Editline: Fix an msan error

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM but this should really be fixed upstream (in libedit) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61191/new/ https://reviews.llvm.org/D61191

[Lldb-commits] [PATCH] D61191: Editline: Fix an msan error

labath added a comment. You can see the relevant part of the source code here https://github.com/cdesjardins/libedit/blob/master/src/eln.c#L310 (not the canonical source, but at least it's easy to link to). @christos, any chance of getting this fixed (either the docs, or the source code)? CH

[Lldb-commits] [PATCH] D61191: Editline: Fix an msan error

labath created this revision. labath added reviewers: christos, krytarowski, davide. Despite the documentation for the el_get(EL_GETTC) function claiming the vararg part is (const char *name, void *value), in reality the function expects the vararg list to be terminated by a null pointer, which ca