[Lldb-commits] [PATCH] D61183: PostfixExpression: Introduce CFANode

labath marked an inline comment as done. labath added inline comments. Comment at: source/Symbol/PostfixExpression.cpp:150 + /// InitialValueNodes in our input expression, we assume the initial stack + /// will contain their value (hence we start with m_stack_depth = 1). If we

[Lldb-commits] [PATCH] D61183: PostfixExpression: Introduce CFANode

This revision was automatically updated to reflect the committed changes. Closed by commit rL359560: PostfixExpression: Introduce InitialValueNode (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews

[Lldb-commits] [PATCH] D61183: PostfixExpression: Introduce CFANode

amccarth accepted this revision. amccarth added a comment. LGTM, but I found one comment a bit confusing for me. Comment at: source/Symbol/PostfixExpression.cpp:150 + /// InitialValueNodes in our input expression, we assume the initial stack + /// will contain their value (he

[Lldb-commits] [PATCH] D61183: PostfixExpression: Introduce CFANode

labath updated this revision to Diff 197086. labath added a comment. s/CFA/InitialValue/ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61183/new/ https://reviews.llvm.org/D61183 Files: include/lldb/Symbol/PostfixExpression.h source/Symbol/PostfixExpression.cpp unittests/Symbol/Po

[Lldb-commits] [PATCH] D61183: PostfixExpression: Introduce CFANode

labath added a comment. In D61183#1480948 , @clayborg wrote: > FYI: for all DWARF expressions found in EH frame stuff, they expect the CFA > address to be pushed onto the stack prior to executing the expression. Do we > just want to follow suit with the

[Lldb-commits] [PATCH] D61183: PostfixExpression: Introduce CFANode

clayborg added a comment. FYI: for all DWARF expressions found in EH frame stuff, they expect the CFA address to be pushed onto the stack prior to executing the expression. Do we just want to follow suit with the these expressions and avoid the extra needed node? CHANGES SINCE LAST ACTION h

[Lldb-commits] [PATCH] D61183: PostfixExpression: Introduce CFANode

labath created this revision. labath added reviewers: amccarth, clayborg, aleksandr.urakov. Herald added a subscriber: aprantl. This node represents the "Canonical Frame Address" of the current frame, and is used by various DWARF expressions to express adresses of various objects relative to the f

[Lldb-commits] [PATCH] D61183: PostfixExpression: Introduce CFANode

labath added a comment. PS: Although this patch is technically dependency free, for this to work as a part of the bigger picture, we'll need to get lldb's dwarf evaluator to actually push the CFA value to the dwarf stack (D61018 ) and fix its implementation of D