[Lldb-commits] [PATCH] D61182: DWARFExpression: Fix implementation of DW_OP_pick

2019-04-29 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB359436: DWARFExpression: Fix implementation of DW_OP_pick (authored by labath, committed by ). Herald added a subscriber: abidh. Herald added a project: LLDB. Changed prior to commit: https://reviews

[Lldb-commits] [PATCH] D61182: DWARFExpression: Fix implementation of DW_OP_pick

2019-04-26 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. labath added reviewers: jasonmolenda, clayborg. Herald added subscribers: aprantl, mgorny. The DWARF spec states that the DWARF stack arguments are numbered from the top. Our implementation of DW_OP_pick was counting them from the bottom. This bug probably wasn't not