[Lldb-commits] [PATCH] D61036: [lldb] Use local definition of get_cpuid_count

This revision was automatically updated to reflect the committed changes. Closed by commit rL359120: [lldb] Use local definition of get_cpuid_count (authored by josepht, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revie

[Lldb-commits] [PATCH] D61036: [lldb] Use local definition of get_cpuid_count

JosephTremoulet added a comment. Switched to static function, and yes I do have commit access. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61036/new/ https://reviews.llvm.org/D61036

[Lldb-commits] [PATCH] D61036: [lldb] Use local definition of get_cpuid_count

JosephTremoulet updated this revision to Diff 196459. JosephTremoulet added a comment. - Use static function rather than anonymous namespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61036/new/ https://reviews.llvm.org/D61036 Files: lldb/sou

[Lldb-commits] [PATCH] D61036: [lldb] Use local definition of get_cpuid_count

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. The chosen approach looks fine to me. The only nit I have is that llvm style prefers `static` functions over ones in anonymous namespaces (though this file is not very consistent in that aspec

[Lldb-commits] [PATCH] D61036: [lldb] Use local definition of get_cpuid_count

JosephTremoulet added a comment. @labath, as discussed in D59991 , I went with a local copy of the function since I didn't see an obvious opportunity to tweak the calling code, but maybe I overlooked something. My copy of cpuid.h matches https://github.com/gcc-

[Lldb-commits] [PATCH] D61036: [lldb] Use local definition of get_cpuid_count

JosephTremoulet created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This is needed for gcc/cstdlib++ 5.4.0, where __get_cpuid_count is not defined in cpuid.h. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D61036 Files: lldb/source/Pl